Skip to content

fix(suspense): Fixed the implementation to apiRef. #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2024
Merged

fix(suspense): Fixed the implementation to apiRef. #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions packages/react-uploader/src/SSR/ConditionalSuspense/ConditionalSuspense.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
import React, { FC, Suspense } from 'react';
import React, { FC, Suspense } from "react";

Check notice

Code scanning / CodeQL

Unused variable, import, function or class

Unused import Suspense.

export type TProps = {
fallback?: React.ReactChild | React.ReactFragment | React.ReactPortal | null;
condition: boolean;
children: React.ReactNode;
// fallback?: React.ReactChild | React.ReactFragment | React.ReactPortal | null;
// condition: boolean;
children: React.ReactNode;
};

export const ConditionalSuspense: FC<TProps> = ({ condition, fallback, children, ...rest }) => {
return condition ? (
<Suspense fallback={fallback} {...rest}>
{children}
</Suspense>
) : (
<>{fallback}</>
);
};
export const ConditionalSuspense: FC<TProps> = ({
// condition,
// fallback,
children,
}) => {
return children;
};