Skip to content

Add e2e tests #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Jun 27, 2025
Merged

Add e2e tests #20

merged 29 commits into from
Jun 27, 2025

Conversation

ytkimirti
Copy link
Collaborator

No description provided.

Copy link

linear bot commented Jun 24, 2025

Copy link

vercel bot commented Jun 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-redis-browser ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2025 7:22am

Copy link

@alitariksahin alitariksahin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may put a cleanup code, flushing the database at the end. However, if you want to keep the dummy keys, you may put an optional script for that cleanup code. Speaking of scripts, you may add a script to run these tests, e.g "test": "playwright tests" and sth like "test:cleanup": "node scripts/cleanup-redis.js" for the cleanup @ytkimirti


await page.getByRole("button", { name: "Cancel" }).press("Escape")

await page.getByRole("menuitem", { name: "Delete key" }).click()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since pressed escape above the context menu is closed, so you cannot click on Delete key again, hence this fails

@ytkimirti
Copy link
Collaborator Author

@alitariksahin I already have it running before the tests and I put a system to dedect if there are any modifications made to the database or not. It should be fine

@ytkimirti ytkimirti merged commit 09ee2df into master Jun 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants