-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/orphan node grouping #45
Conversation
e9be803
to
55584d4
Compare
55584d4
to
7df1a69
Compare
Remaining issues:
Code to test
|
Hey @jayqi , I see the function plots looking terrible as a separate issue at the moment than orphan grouping. I would support merging this PR today (after updates to pass tests) and fixing the graph layouts in a later PR soon after. |
Weirdly it looks weird with
|
"packagePath" | ||
"packagePath", | ||
"cache", | ||
"defaultCache" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If only real life cash multiplied like pkgnet
cache ...
return(orphanNodes) | ||
}, | ||
|
||
graph_layout_functions = list( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this. Clean and structured.
@jayqi Looks good. I'm going to merge it. For posterity, the example to run for this is:
|
WIP for #28