Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/orphan node grouping #45

Merged
merged 3 commits into from
Feb 10, 2018

Conversation

jayqi
Copy link
Collaborator

@jayqi jayqi commented Jan 12, 2018

WIP for #28

@jayqi jayqi force-pushed the feature/orphan-node-grouping branch from 55584d4 to 7df1a69 Compare February 9, 2018 22:18
@jayqi
Copy link
Collaborator Author

jayqi commented Feb 9, 2018

Remaining issues:

  • Orphan Node grouping still looks terrible with the layouts
  • tree' layout has a mysterious bug where regenerating the plot will alternate between no-layout and tree-layout. For some reason this doesn't happen with circle`.

Code to test

myFuncReporter <- PackageFunctionReporter$new()
myFuncReporter$set_package('lubridate')
myFuncReporter$orphanNodeClusteringThreshold <- 3
myFuncReporter$graphLayoutType <- 'tree'
myFuncReporter$plot_network()

@jayqi
Copy link
Collaborator Author

jayqi commented Feb 9, 2018

Lubridate + tree
lubridate_tree

Lubridate + bugged no-layout
lubridate_no-layout

Lubridate + circle
lubridate_circle

@bburns632
Copy link
Collaborator

Hey @jayqi ,

I see the function plots looking terrible as a separate issue at the moment than orphan grouping. I would support merging this PR today (after updates to pass tests) and fixing the graph layouts in a later PR soon after.

@jayqi
Copy link
Collaborator Author

jayqi commented Feb 10, 2018

Weirdly it looks weird with lubridate but it works fine with something smaller like uptasticsearch. /shrug

myFuncReporter <- PackageFunctionReporter$new()
myFuncReporter$set_package('uptasticsearch')
myFuncReporter$orphanNodeClusteringThreshold <- 3
myFuncReporter$graphLayoutType <- 'tree'
myFuncReporter$plot_network()

screen shot 2018-02-09 at 6 43 22 pm

"packagePath"
"packagePath",
"cache",
"defaultCache"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only real life cash multiplied like pkgnet cache ...

return(orphanNodes)
},

graph_layout_functions = list(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. Clean and structured.

@bburns632
Copy link
Collaborator

@jayqi Looks good. I'm going to merge it.

For posterity, the example to run for this is:

myFuncReporter <- PackageFunctionReporter$new()
myFuncReporter$set_package('uptasticsearch')
myFuncReporter$orphanNodeClusteringThreshold <- 3
#myFuncReporter$graphLayoutType <- 'tree'
myFuncReporter$layoutType <- 'tree'
myFuncReporter$plot_network()

@bburns632 bburns632 merged commit 49d3c8c into uptake:master Feb 10, 2018
@jayqi jayqi deleted the feature/orphan-node-grouping branch March 8, 2018 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants