Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker: support --loom and other options in start-urbit script #189

Closed
nodreb-borrus opened this issue Feb 1, 2023 · 2 comments · Fixed by #221
Closed

Docker: support --loom and other options in start-urbit script #189

nodreb-borrus opened this issue Feb 1, 2023 · 2 comments · Fixed by #221
Labels
good first issue Good for newcomers

Comments

@nodreb-borrus
Copy link

The start-urbit script is particular about what options it supports and does not pass through arbitrary options. It does not support --loom and we can work around this for existing ships by calling urbit directly and not start-urbit. There was a fix under review for this in the old repo but I never tried it out myself:

urbit/urbit#6110

Old issue: urbit/urbit#6130
@mcevoypeter mcevoypeter added the good first issue Good for newcomers label Feb 1, 2023
@mcevoypeter
Copy link

This change should be simple and confined entirely to the start-urbit Bash script. The relevant file to change is docker/start_urbit.sh.

@mopfel-winrux
Copy link
Contributor

This was originally submitted in the old repo as a PR. urbit/urbit#6110

@mopfel-winrux mopfel-winrux mentioned this issue Feb 10, 2023
Merged
matthew-levan added a commit that referenced this issue Feb 14, 2023
@matthew-levan
Docker: Support for --loom and --httpPort (#221)
1a9f3ab 
Modified start_urbit.sh script to allow the user to pick loom size and
http port.
This is the start script Native Planet uses for our docker container

Resolves #189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Docker: Support for --loom and --httpPort mopfel-winrux/vere
3 participants
@mopfel-winrux @mcevoypeter @nodreb-borrus