Docker: Support for --loom and --httpPort
#221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If Native Planet is taking over ownership of the Docker container, I think it makes sense to change CODEOWNERS to list your team as owners of the |
|
Agree completely. Let's make sure to due that durning one of our weekly meetings, probably tomorrow, @mopfel-winrux |
|
@mopfel-winrux will you please test this image and copy/paste the results in here? Maybe just a simple build, start (with new options), and verify that the boot prints match the expected inputs (namely Once I see those results I'll gladly approve. Thank you sir. |
Added loom and httpPort for comets :(
Added stuff about loom and http-port
|
@mopfel-winrux and I tested this live this morning and all the new options work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified start_urbit.sh script to allow the user to pick loom size and http port.
This is the start script Native Planet uses for our docker container
Resolves #189