Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Porting main to v3-dev-main circa 2022-11-06 #1569

Merged
merged 211 commits into from
Nov 8, 2022
Merged

Porting main to v3-dev-main circa 2022-11-06 #1569

merged 211 commits into from
Nov 8, 2022

Conversation

meatballhat
Copy link
Member

What type of PR is this?

(REQUIRED)

  • maintenance

What this PR does / why we need it:

(REQUIRED)

Getting the v3-dev-main branch caught up with main, this time in preparation for becoming the new main branch 🎉

Which issue(s) this PR fixes:

(REQUIRED)

NA 😬

meatballhat and others added 30 commits July 16, 2022 08:03
@meatballhat
Merge remote-tracking branch 'origin/main' into merging-main-to-v3-de…
c0f57e0 
…v-main
@meatballhat
Merge pull request #1437 from urfave/merging-main-to-v3-dev-main
cb7532a 
Merging main to v3 dev main
@meatballhat
Target minimum go 1.18 in v3-dev-main
887d31f
@dearchap
Merge pull request #1438 from urfave/v3-target-1.18-min
3216104 
Target minimum go 1.18 in v3-dev-main
@dearchap
Cleanup: Collapse flag interfaces
ab68d8a
@dearchap
Remove all flag interfaces
268cb97
@dearchap
Run gofmt
069c6bf
@dearchap
Update godoc
7e80d20
@dearchap
Merge pull request #1471 from dearchap/collapse_flag_interface
0a88df4 
Collapse flag interface
@meatballhat
Bump declared module and internal usage to /v3/
93a3190
@meatballhat
Soft revert go.mod version bump
22ff9a3
@meatballhat
Add stub for v3 docs + point gfmrun there instead
40d886b
@hmiyado @meatballhat
Fix for TimestampFlag.GetValue to return empty string without value
dd9cd61
@meatballhat
Fix HideHelp
67f592a
@meatballhat
Fix After not run
02eb392
@dearchap @meatballhat
issue_62: Make slice options more posix like
bc99b58
@dearchap @meatballhat
Changes from code review
45a1375
@meatballhat
Move genflags tool to cmd/ and pin to previous release
2ca9143 
to alleviate problems caused by the circular dependency of using the
same code as a library that is potentially being generated to adhere to
a different API.
@meatballhat
Tidy up top-level go.mod
d8de3b5
@meatballhat
Add missing go.sum entries for go 1.16.x
a5313eb
@meatballhat
Turn off docs publishing from v3 series
67b3de0
@meatballhat
Use goimports as formatting standard
cbc7f1a 
given some disagreement with gofmt that seems to have shown up in 1.19
@meatballhat
Shift supported go versions
76bb9f1 
and approve word-wrapping changes to godoc
@hay-kot @meatballhat
split v1 docs into individual pages
1ae70fc
@hay-kot @meatballhat
breakup v2 documentation
edaf885
@hay-kot @meatballhat
update sidebar configuration
18f8e6d
@hay-kot @meatballhat
add tags plugin
7cfafe8
@hay-kot @meatballhat
add tags and boost for pages
8036eac
@hay-kot @meatballhat
wip: add --walk flag to gfrun to accept directory
d217a5a
@hay-kot @meatballhat
pass in correct root
87f003f
@meatballhat
Copy link
Member Author

gpg goop all better now 👍🏼 I'll be working on the test failures!

@meatballhat
Copy link
Member Author

Current weirdness is that goimports wants to use "github.com/urfave/cli/v2" in altsrc/flag_generated.go instead of "github.com/urfave/cli/v3" 🤔

Screenshot_2022-11-08_08-28-24

@meatballhat
Copy link
Member Author

It wasn't goimports at all 😅

@meatballhat meatballhat marked this pull request as ready for review November 8, 2022 14:19
@meatballhat meatballhat requested a review from a team as a code owner November 8, 2022 14:19
dearchap
dearchap reviewed Nov 8, 2022
View reviewed changes
command.go Outdated Show resolved Hide resolved
dearchap
dearchap reviewed Nov 8, 2022
View reviewed changes
app.go Outdated Show resolved Hide resolved
dearchap
dearchap reviewed Nov 8, 2022
View reviewed changes
app_test.go Outdated Show resolved Hide resolved
dearchap
dearchap reviewed Nov 8, 2022
View reviewed changes
category.go Outdated Show resolved Hide resolved
dearchap
dearchap previously approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@dearchap dearchap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With comments

@meatballhat meatballhat merged commit c296830 into main Nov 8, 2022
@meatballhat meatballhat deleted the v3-porting branch November 8, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dearchap dearchap dearchap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.