Fix:(issue_1610). Keep RunAsSubcommand behaviour as before #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works for me (RunAsSubcommand seems to behave as before). But also this forces me to keep using the method marked as deprecated. The new RunAsSubcommand implementation uses internal methods/fields so I cannot just do the things directly on my code. Would we un-deprecate the method? |
|
@hsanjuan Removed the deprecate. |
another-rex
referenced
this pull request
in google/osv-scanner
Jun 6, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/BurntSushi/toml](https://togithub.com/BurntSushi/toml) | require | minor | `v1.2.1` -> `v1.3.0` | | [github.com/go-git/go-git/v5](https://togithub.com/go-git/go-git) | require | minor | `v5.6.1` -> `v5.7.0` | | [github.com/spdx/tools-golang](https://togithub.com/spdx/tools-golang) | require | patch | `v0.5.0` -> `v0.5.1` | | [github.com/urfave/cli/v2](https://togithub.com/urfave/cli) | require | patch | `v2.25.3` -> `v2.25.5` | | golang.org/x/exp | require | digest | `dd950f8` -> `2e198f4` | | golang.org/x/tools | require | patch | `v0.9.1` -> `v0.9.3` | --- ### Release Notes <details> <summary>BurntSushi/toml</summary> ### [`v1.3.0`](https://togithub.com/BurntSushi/toml/releases/tag/v1.3.0) [Compare Source](https://togithub.com/BurntSushi/toml/compare/v1.2.1...v1.3.0) New features: - Support upcoming TOML 1.1 While it looks like TOML 1.1 is mostly stable and I don't expect any further major changes, there are *NO* compatibility guarantees as it is *NOT* yet released and *anything can still change*. To use it, set the `BURNTSUSHI_TOML_110` environment variable to any value, which can be done either with `os.SetEnv()` or by the user running a program. A full list is changes is available in the [TOML ChangeLog]; the two most notable ones are that newlines and trailing commas are now allowed in inline tables, and Unicode in bare keys can now be used – this is now a valid document: lëttërs = { ä = "a with diaeresis", è = "e with accent grave", } [TOML ChangeLog]: https://togithub.com/toml-lang/toml/blob/main/CHANGELOG.md - Allow MarshalTOML and MarshalText to be used on the document type itself, instead of only fields ([#​383](https://togithub.com/BurntSushi/toml/issues/383)). Bufixes: - `\` escapes at the end of line weren't processed correctly in multiline strings ([#​372](https://togithub.com/BurntSushi/toml/issues/372)). - Read over UTF-8 BOM ([#​381](https://togithub.com/BurntSushi/toml/issues/381)). - `omitempty` struct tag did not work for pointer values ([#​371](https://togithub.com/BurntSushi/toml/issues/371)). - Fix encoding anonymous structs on 32bit systems ([#​374](https://togithub.com/BurntSushi/toml/issues/374)). </details> <details> <summary>go-git/go-git</summary> ### [`v5.7.0`](https://togithub.com/go-git/go-git/releases/tag/v5.7.0) [Compare Source](https://togithub.com/go-git/go-git/compare/v5.6.1...v5.7.0) #### What's Changed - \*: Add support for initializing SHA256 repositories by [@​pjbgf](https://togithub.com/pjbgf) in [https://github.com/go-git/go-git/pull/707](https://togithub.com/go-git/go-git/pull/707) - git: add mirror clone option by [@​aymanbagabas](https://togithub.com/aymanbagabas) in [https://github.com/go-git/go-git/pull/735](https://togithub.com/go-git/go-git/pull/735) - git: Add support to ls-remote with peeled references. Fixes [#​749](https://togithub.com/go-git/go-git/issues/749) by [@​pjbgf](https://togithub.com/pjbgf) in [https://github.com/go-git/go-git/pull/750](https://togithub.com/go-git/go-git/pull/750) - git: fix cloning with branch name by [@​AriehSchneier](https://togithub.com/AriehSchneier) in [https://github.com/go-git/go-git/pull/755](https://togithub.com/go-git/go-git/pull/755) - git: Worktree, add check to see if file already checked in. Fixes [#​718](https://togithub.com/go-git/go-git/issues/718) by [@​cbbm142](https://togithub.com/cbbm142) in [https://github.com/go-git/go-git/pull/719](https://togithub.com/go-git/go-git/pull/719) - git: Worktree, git grep bare repositories by [@​aymanbagabas](https://togithub.com/aymanbagabas) in [https://github.com/go-git/go-git/pull/728](https://togithub.com/go-git/go-git/pull/728) - git: Add Depth to SubmoduleUpdateOptions by [@​matejrisek](https://togithub.com/matejrisek) in [https://github.com/go-git/go-git/pull/754](https://togithub.com/go-git/go-git/pull/754) - git: Testing, Fix tests not cleaning temp folders by [@​AriehSchneier](https://togithub.com/AriehSchneier) in [https://github.com/go-git/go-git/pull/769](https://togithub.com/go-git/go-git/pull/769) - git: remote, add support for a configurable timeout. by [@​andrewpollock](https://togithub.com/andrewpollock) in [https://github.com/go-git/go-git/pull/753](https://togithub.com/go-git/go-git/pull/753) - git: Allow Initial Branch to be configurable by [@​techknowlogick](https://togithub.com/techknowlogick) in [https://github.com/go-git/go-git/pull/764](https://togithub.com/go-git/go-git/pull/764) - storage: filesystem/dotgit, Improve load packed-refs by [@​fcharlie](https://togithub.com/fcharlie) in [https://github.com/go-git/go-git/pull/743](https://togithub.com/go-git/go-git/pull/743) - storage: filesystem, Populate index before use. Fixes [#​148](https://togithub.com/go-git/go-git/issues/148) by [@​AriehSchneier](https://togithub.com/AriehSchneier) in [https://github.com/go-git/go-git/pull/722](https://togithub.com/go-git/go-git/pull/722) - plumbing: resolve non-external delta references by [@​ZauberNerd](https://togithub.com/ZauberNerd) in [https://github.com/go-git/go-git/pull/485](https://togithub.com/go-git/go-git/pull/485) - plumbing/transport: fix regression in scp-like match by [@​jotadrilo](https://togithub.com/jotadrilo) in [https://github.com/go-git/go-git/pull/715](https://togithub.com/go-git/go-git/pull/715) - plumbing/transport: Add support for custom proxy settings by [@​aryan9600](https://togithub.com/aryan9600) in [https://github.com/go-git/go-git/pull/744](https://togithub.com/go-git/go-git/pull/744) - \*: small fixes across the codebase by [@​pjbgf](https://togithub.com/pjbgf) in [https://github.com/go-git/go-git/pull/770](https://togithub.com/go-git/go-git/pull/770) - \*: bump github.com/cloudflare/circl from 1.1.0 to 1.3.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-git/go-git/pull/776](https://togithub.com/go-git/go-git/pull/776) - \*: bump dependencies by [@​pjbgf](https://togithub.com/pjbgf) in [https://github.com/go-git/go-git/pull/748](https://togithub.com/go-git/go-git/pull/748) - \*: bump Go version to 1.18 on go.mod by [@​pjbgf](https://togithub.com/pjbgf) in [https://github.com/go-git/go-git/pull/774](https://togithub.com/go-git/go-git/pull/774) - \*: add Codeql workflow and bump dependencies by [@​pjbgf](https://togithub.com/pjbgf) in [https://github.com/go-git/go-git/pull/775](https://togithub.com/go-git/go-git/pull/775) - ci: fix upstream git build for master branch by [@​pjbgf](https://togithub.com/pjbgf) in [https://github.com/go-git/go-git/pull/739](https://togithub.com/go-git/go-git/pull/739) #### New Contributors - [@​ZauberNerd](https://togithub.com/ZauberNerd) made their first contribution in [https://github.com/go-git/go-git/pull/485](https://togithub.com/go-git/go-git/pull/485) - [@​jotadrilo](https://togithub.com/jotadrilo) made their first contribution in [https://github.com/go-git/go-git/pull/715](https://togithub.com/go-git/go-git/pull/715) - [@​fcharlie](https://togithub.com/fcharlie) made their first contribution in [https://github.com/go-git/go-git/pull/743](https://togithub.com/go-git/go-git/pull/743) - [@​AriehSchneier](https://togithub.com/AriehSchneier) made their first contribution in [https://github.com/go-git/go-git/pull/755](https://togithub.com/go-git/go-git/pull/755) - [@​cbbm142](https://togithub.com/cbbm142) made their first contribution in [https://github.com/go-git/go-git/pull/719](https://togithub.com/go-git/go-git/pull/719) - [@​aryan9600](https://togithub.com/aryan9600) made their first contribution in [https://github.com/go-git/go-git/pull/744](https://togithub.com/go-git/go-git/pull/744) - [@​matejrisek](https://togithub.com/matejrisek) made their first contribution in [https://github.com/go-git/go-git/pull/754](https://togithub.com/go-git/go-git/pull/754) - [@​andrewpollock](https://togithub.com/andrewpollock) made their first contribution in [https://github.com/go-git/go-git/pull/753](https://togithub.com/go-git/go-git/pull/753) - [@​techknowlogick](https://togithub.com/techknowlogick) made their first contribution in [https://github.com/go-git/go-git/pull/764](https://togithub.com/go-git/go-git/pull/764) **Full Changelog**: go-git/go-git@v5.6.1...v5.7.0 </details> <details> <summary>spdx/tools-golang</summary> ### [`v0.5.1`](https://togithub.com/spdx/tools-golang/releases/tag/v0.5.1) [Compare Source](https://togithub.com/spdx/tools-golang/compare/v0.5.0...v0.5.1) #### What's Changed - Add ability to specify JSON output options by [@​DmitriyLewen](https://togithub.com/DmitriyLewen) in [https://github.com/spdx/tools-golang/pull/213](https://togithub.com/spdx/tools-golang/pull/213) - Fix some optional params: `copyrightText`, `licenseListVersion`, `packageVerificationCode` by [@​lumjjb](https://togithub.com/lumjjb) in [https://github.com/spdx/tools-golang/pull/215](https://togithub.com/spdx/tools-golang/pull/215) - Properly output and read the `filesAnalyzed` field in JSON/YAML by [@​kzantow](https://togithub.com/kzantow) in [https://github.com/spdx/tools-golang/pull/210](https://togithub.com/spdx/tools-golang/pull/210) - Ensure no duplicates in relationships when shortcut fields are used. by [@​lumjjb](https://togithub.com/lumjjb) in [https://github.com/spdx/tools-golang/pull/218](https://togithub.com/spdx/tools-golang/pull/218) #### New Contributors - [@​testwill](https://togithub.com/testwill) made their first contribution in [https://github.com/spdx/tools-golang/pull/212](https://togithub.com/spdx/tools-golang/pull/212) - [@​DmitriyLewen](https://togithub.com/DmitriyLewen) made their first contribution in [https://github.com/spdx/tools-golang/pull/213](https://togithub.com/spdx/tools-golang/pull/213) **Full Changelog**: spdx/tools-golang@v0.5.0...v0.5.1 </details> <details> <summary>urfave/cli</summary> ### [`v2.25.5`](https://togithub.com/urfave/cli/releases/tag/v2.25.5) [Compare Source](https://togithub.com/urfave/cli/compare/v2.25.4...v2.25.5) #### What's Changed - Fix:(issue\_1737) Set bool count by taking care of num of aliases by [@​dearchap](https://togithub.com/dearchap) in [https://github.com/urfave/cli/pull/1740](https://togithub.com/urfave/cli/pull/1740) **Full Changelog**: urfave/cli@v2.25.4...v2.25.5 ### [`v2.25.4`](https://togithub.com/urfave/cli/releases/tag/v2.25.4) [Compare Source](https://togithub.com/urfave/cli/compare/v2.25.3...v2.25.4) #### What's Changed - Bug/fix issue 1703 by [@​jojje](https://togithub.com/jojje) in [https://github.com/urfave/cli/pull/1728](https://togithub.com/urfave/cli/pull/1728) - Fix:(issue\_1734) Show categories for subcommands by [@​dearchap](https://togithub.com/dearchap) in [https://github.com/urfave/cli/pull/1735](https://togithub.com/urfave/cli/pull/1735) - Fix:(issue\_1610). Keep RunAsSubcommand behaviour as before by [@​dearchap](https://togithub.com/dearchap) in [https://github.com/urfave/cli/pull/1736](https://togithub.com/urfave/cli/pull/1736) - Fix:(issue\_1731) Add fix for checking if aliases are set by [@​dearchap](https://togithub.com/dearchap) in [https://github.com/urfave/cli/pull/1732](https://togithub.com/urfave/cli/pull/1732) - Fix func name referenced in doc comment by [@​meatballhat](https://togithub.com/meatballhat) in [https://github.com/urfave/cli/pull/1738](https://togithub.com/urfave/cli/pull/1738) #### New Contributors - [@​jojje](https://togithub.com/jojje) made their first contribution in [https://github.com/urfave/cli/pull/1728](https://togithub.com/urfave/cli/pull/1728) **Full Changelog**: urfave/cli@v2.25.3...v2.25.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on monday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/google/osv-scanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40OC4yIiwidXBkYXRlZEluVmVyIjoiMzUuMTAyLjEwIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
kyubisation
referenced
this pull request
in kyubisation/angular-static-server
Aug 20, 2023
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/urfave/cli/v2](https://togithub.com/urfave/cli) | require | patch | `v2.25.3` -> `v2.25.7` | --- ### Release Notes <details> <summary>urfave/cli (github.com/urfave/cli/v2)</summary> ### [`v2.25.7`](https://togithub.com/urfave/cli/releases/tag/v2.25.7) [Compare Source](https://togithub.com/urfave/cli/compare/v2.25.6...v2.25.7) #### What's Changed - Fix: fix v2 broken tests by [@​dearchap](https://togithub.com/dearchap) in [https://github.com/urfave/cli/pull/1757](https://togithub.com/urfave/cli/pull/1757) - Fix:(issue\_1755) Ensure that timestamp flag destination is set correctly by [@​dearchap](https://togithub.com/dearchap) in [https://github.com/urfave/cli/pull/1756](https://togithub.com/urfave/cli/pull/1756) **Full Changelog**: urfave/cli@v2.25.6...v2.25.7 ### [`v2.25.6`](https://togithub.com/urfave/cli/releases/tag/v2.25.6) [Compare Source](https://togithub.com/urfave/cli/compare/v2.25.5...v2.25.6) #### What's Changed - Fix:(issue\_1668) Add test case for sub command of sub command completion by [@​dearchap](https://togithub.com/dearchap) in [https://github.com/urfave/cli/pull/1747](https://togithub.com/urfave/cli/pull/1747) - Update dependencies for v2 by [@​meatballhat](https://togithub.com/meatballhat) in [https://github.com/urfave/cli/pull/1749](https://togithub.com/urfave/cli/pull/1749) - Document slice flags as part of examples (v2) by [@​carhartl](https://togithub.com/carhartl) in [https://github.com/urfave/cli/pull/1751](https://togithub.com/urfave/cli/pull/1751) **Full Changelog**: urfave/cli@v2.25.5...v2.25.6 ### [`v2.25.5`](https://togithub.com/urfave/cli/releases/tag/v2.25.5) [Compare Source](https://togithub.com/urfave/cli/compare/v2.25.4...v2.25.5) #### What's Changed - Fix:(issue\_1737) Set bool count by taking care of num of aliases by [@​dearchap](https://togithub.com/dearchap) in [https://github.com/urfave/cli/pull/1740](https://togithub.com/urfave/cli/pull/1740) **Full Changelog**: urfave/cli@v2.25.4...v2.25.5 ### [`v2.25.4`](https://togithub.com/urfave/cli/releases/tag/v2.25.4) [Compare Source](https://togithub.com/urfave/cli/compare/v2.25.3...v2.25.4) #### What's Changed - Bug/fix issue 1703 by [@​jojje](https://togithub.com/jojje) in [https://github.com/urfave/cli/pull/1728](https://togithub.com/urfave/cli/pull/1728) - Fix:(issue\_1734) Show categories for subcommands by [@​dearchap](https://togithub.com/dearchap) in [https://github.com/urfave/cli/pull/1735](https://togithub.com/urfave/cli/pull/1735) - Fix:(issue\_1610). Keep RunAsSubcommand behaviour as before by [@​dearchap](https://togithub.com/dearchap) in [https://github.com/urfave/cli/pull/1736](https://togithub.com/urfave/cli/pull/1736) - Fix:(issue\_1731) Add fix for checking if aliases are set by [@​dearchap](https://togithub.com/dearchap) in [https://github.com/urfave/cli/pull/1732](https://togithub.com/urfave/cli/pull/1732) - Fix func name referenced in doc comment by [@​meatballhat](https://togithub.com/meatballhat) in [https://github.com/urfave/cli/pull/1738](https://togithub.com/urfave/cli/pull/1738) #### New Contributors - [@​jojje](https://togithub.com/jojje) made their first contribution in [https://github.com/urfave/cli/pull/1728](https://togithub.com/urfave/cli/pull/1728) **Full Changelog**: urfave/cli@v2.25.3...v2.25.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/angular-static-server/angular-static-server). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40My4yIiwidXBkYXRlZEluVmVyIjoiMzYuNDMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #1610
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)
Release Notes
(REQUIRED)