build: show failures when running tests

[coilysiren]

Before

When you have failing tests, you get output like this

go run build.go generate
go run build.go vet
go run build.go test
exit status 1
exit status 1
Command exited with code 1

The above output is the literal terminal output, it doesn't tell the user what the source of the test failure is.

Adding the verbose flag like so

go run -v build.go test

Does not fix the issue.

After

When you have failing tests, you get output like this

go run -v build.go test
...
--- FAIL: TestToMan (0.00s)
...
FAIL
coverage: 84.0% of statements
FAIL	github.com/urfave/cli	0.089s
exit status 1
exit status 1

This gives the user enough information to resolve the issue.

Changes

I hooked Stdin, Stdout, Stderr into the ox exec calls.

Impact

This change effects the local build system, and does not relate to the functionality of the cli.

Context

This change is followup from #836

[saschagrunert]

Overall LGTM, just one single comment which is a non-blocker 👇

[AudriusButkevicius]

Actually, I think having runCmd(string... args) would make sense as @saschagrunert suggested, to avoid repetition.

[codecov]

Codecov Report

Merging #873 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #873   +/-   ##
=======================================
  Coverage   71.33%   71.33%           
=======================================
  Files          18       18           
  Lines        2362     2362           
=======================================
  Hits         1685     1685           
  Misses        572      572           
  Partials      105      105

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 392c1de...d3edef8. Read the comment docs.

[saschagrunert]

I’m not blocking in my comment, LGTM.