fix(auth): Catch unexpected errors during initialization #3343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: vercel/next.js#49373
Summary
It's unexpected and undefined behaviour to throw/reject in the initialization function passed to the
authExchange()
and any rejections will be uncaught.This can make thes situations hard to debug, as the promise will be uncaught.
Instead, errors during initialization will now be caught, queued up
Operation
s will be fulfilled with anOperationResult
with their error populated to the caught error, and a warning will be output in development that tells users what's going on.This essentially allows uncaught errors in the initialization function to be discovered and handled properly. At worst, it'll fail all operations coming in and will retry the initialization function if the operations are retried.
Set of changes
errorQueue
config
is not initialized