Move next-urql to monorepo #557

parkerziegler · 2020-02-28T23:24:52Z

NOTE: Please don't squash & merge, but do a merge commit.

… doscumentation and example README instructions.

…Add TypeScript definitions. (#2) * Improve publishing steps. Add formal LICENSE. Improve documentation. Add TypeScript definitions. * Remove declaration: true from tsconfig. * PR feedback. Improve README language around automatic static optimization. Add CONTRIBUTING.md. Adjust ESLint settings.

* Add support for accessing ctx in withUrqlClient. * Update TS definitions. Add test of mergeExchanges.

…CHANGELOG for v0.2.0 release.

* Prevent circular structure in getInitialProps. * Update TS defs to better match wrapped components that implement their own getInitialProps. * Final edits to index.d.ts.

* Fix support for using withUrqlClient with _app.js Co-authored-by: bmathews <brian.mathews@formidable.com> * Update example READMEs. * Final adjustments to index.d.ts Co-authored-by: Brian Mathews <spoonart@gmail.com>

* add urqlClient to Page Context * revert import ordering * add urqClient to PageProps interface in index.d.ts * move type to NextContextWithAppTree

* Add auto-generated tsconfig.json and next-env.d.ts * Convert components and pages to TypeScript * Use correct NextContext type * Point TS compiler to next-urql at root of the repo * Update example to use our custom NextContext

* Convert example 2 to TypeScript * Add `tsconfig.json` and `next-env.d.ts` * JS -> TS conversion * Add types for pokemon data * Add type for Next App * Refactor pokemon type mapping * Use AppPropsType from Next

* Upgrade to Next 9 (test fixes WIP) * Remove deprecated `@types/next` * Add `next@9.1.7` to devDependencies * Replace `NextComponentClass` | `NextFC` union describing `Page` with `NextPage` * Rename `NextContextWithAppTree` to `NextUrqlContext` * Make `NextUrqlContext` extend `NextPageContext` instead of `NextContext` * Import types directly from top-level next * Coerce mock request object * Fix withUrqlClient test config * Coerce ctx into more accurate representation

…velopment environments. (#30) * Add Travis CI. Autogenerate TS defs into dist. Add displayName for development environments. * Fix issues with Rollup not transforming regeneratorRuntime in examples. * Use correct name for formatting script in CI. * Add in Buble. * Preserve displayName in all environments. Add build badge to README.

* Add initial custom exchange example * Remove console log

* Remove serialization of clientOptions in getInitialProps. * Remove unnecessary console.log. * Remove another console.log. * Move mockMergeExchanges to upper describe block. * Move beforeEach rendering component into relevant describe block. * Remove test stage as Travis explicitly includes it.

* bump react-ssr-prepass to 1.1.1 to fix the suspense bug * use 1.1.2 this includes some refactors

* Add better support for _app.js. Move types to separate module. * Remove unnecessary type casting. * Fix type issues in tests by relaxing types 😂

…731be96be7' git-subtree-dir: packages/next-urql git-subtree-mainline: 814fb04 git-subtree-split: 321328c

changeset-bot · 2020-02-28T23:24:54Z

🦋 Changeset is good to go

Latest commit: 2a24461

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

parkerziegler · 2020-03-01T19:03:06Z

@JoviDeCroock @kitten and I cranked this out on Friday afternoon. I think we should be good to merge, but let me know if you'd like any additional bits brought in here. We used git subtree for this (thanks for showing me that Phil!) so it should preserve the whole commit history. A few snags getting the build working with the shared Rollup setup but otherwise looking good. Once we merge I'll archive the next-urql repo and transfer open issues over here.

JoviDeCroock

Nice work Parker! Some minor nits but all fine on my part 👍

JoviDeCroock · 2020-03-01T19:14:28Z

packages/next-urql/README.md

+npm install --save next-urql urql react-is isomorphic-unfetch
+```
+
+`react-is`, `styled-components`, and `isomorphic-unfetch` help to support server-side `Suspense` with `react-ssr-prepass`. This assumes you have followed the basic installation steps for `urql` [here](https://github.com/FormidableLabs/urql#installation).


is styled-components needed since it's not in the above install

Good point! That’s not required anymore

Good catch, will remove it. It used to be needed in previous versions of react-ssr-prepass, but no longer!

JoviDeCroock · 2020-03-01T19:15:19Z

packages/next-urql/examples/1-with-urql-client/.gitignore

@@ -0,0 +1,25 @@
+# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.


We might want to add these to the global gitignore instead to reduce files (same for the logo maybe use them from /docs)

I think it’s fine to make an exception for examples until those are cleaned up maybe? 🤔

✅ Agreed, will do.

parkerziegler and others added 30 commits October 16, 2019 16:15

Initial commit.

b7d4bec

Check in initial work on README before beginning API rework.

f87b07f

Add setup for Babel, Rollup, Jest. Begin working on NextJS example.

5792711

Add next.config.js to example. Being to isolate peerDependencies.

0577548

Check in progress on example and rollup config.

01a25f6

Add bash script to assist in example dependency installation. Add API…

cb9e566

… doscumentation and example README instructions.

Add Pokemon type icons to example.

3fb2950

README edits.

931103d

Last cleanup before 0.1.0 publish.

85e778c

Check in initial CHANGELOG. Add npm badge to repo.

92e8ba0

Add example CodeSandbox link to repo.

a4edc9d

Changes for version 0.1.1

2d49fa0

v0.1.1

62d11d2

Add support for accessing Next context to configure urql Client. (#4)

c207c9b

* Add support for accessing ctx in withUrqlClient. * Update TS definitions. Add test of mergeExchanges.

Add updated documentation on accessing ctx in withUrqlClient. Update …

fdb5d33

…CHANGELOG for v0.2.0 release.

v0.2.0

f7cfcfe

Prevent circular structure in getInitialProps. (#7)

e1f2f3e

* Prevent circular structure in getInitialProps. * Update TS defs to better match wrapped components that implement their own getInitialProps. * Final edits to index.d.ts.

Prepare v0.2.1 release.

5c7b5c6

v0.2.1

d0d3751

Fix first argument type for withUrqlClient (#9)

a300c94

Prepare v0.2.2 release.

72a0272

v0.2.2

510b3f5

Fix a few typos in the README.

e388ae1

Fix support for using withUrqlClient with _app.js. (#13)

b6540db

* Fix support for using withUrqlClient with _app.js Co-authored-by: bmathews <brian.mathews@formidable.com> * Update example READMEs. * Final adjustments to index.d.ts Co-authored-by: Brian Mathews <spoonart@gmail.com>

Prepare v0.2.3 release.

f299f4e

v0.2.3

7f8aab1

add urqlClient to Page Context (#15)

46f943e

* add urqlClient to Page Context * revert import ordering * add urqClient to PageProps interface in index.d.ts * move type to NextContextWithAppTree

Prepare 0.2.4 release.

8ad2417

Add urqlClient to mocked Next context object.

9b7b72d

parkerziegler and others added 23 commits January 9, 2020 10:36

v0.2.4

104d4eb

chore: Convert example 2-with-_app.js to TypeScript (#21)

7294a67

* Convert example 2 to TypeScript * Add `tsconfig.json` and `next-env.d.ts` * JS -> TS conversion * Add types for pokemon data * Add type for Next App * Refactor pokemon type mapping * Use AppPropsType from Next

Prepare v0.2.5.

2fce343

v0.2.5

2fdd0e2

Add instructions on using next-urql with ReasonML. (#28)

32580de

Update for missing peer dependencies (#29)

d7ea8c0

Add custom exchange example (#32)

1ad4fc0

* Add initial custom exchange example * Remove console log

bump react-ssr-prepass to 1.1.2 to fix the suspense bug (#37)

1634ebd

* bump react-ssr-prepass to 1.1.1 to fix the suspense bug * use 1.1.2 this includes some refactors

Add better support for _app.js. Move types to separate module. (#38)

90261db

* Add better support for _app.js. Move types to separate module. * Remove unnecessary type casting. * Fix type issues in tests by relaxing types 😂

Prepare v0.3.0 release.

af08e62

v0.2.0

d043fa1

v0.3.0

a557e7c

Demonstrate usage of getInitialProps in _app.js. (#40)

321328c

Add 'packages/next-urql/' from commit '321328ce26fd20edb34ddd47b0576d…

f0b44c9

…731be96be7' git-subtree-dir: packages/next-urql git-subtree-mainline: 814fb04 git-subtree-split: 321328c

Clean up old next-urql configs

53b6d69

Fix build for next-urql

7de8671

Add correct next-urql test setup

e8fae7d

Lint next-urql files

bdbfd50

Update CHANGELOG and add changeset to next-urql

582d366

JoviDeCroock approved these changes Mar 1, 2020

View reviewed changes

Remove .gitignore in individual files. Edit README.

2a24461

kitten approved these changes Mar 1, 2020

View reviewed changes

parkerziegler merged commit 1aa1553 into master Mar 1, 2020

parkerziegler deleted the task/add-next-urql branch March 1, 2020 20:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move next-urql to monorepo #557

Move next-urql to monorepo #557

parkerziegler commented Feb 28, 2020

changeset-bot bot commented Feb 28, 2020 •

edited

Loading

parkerziegler commented Mar 1, 2020

JoviDeCroock left a comment

JoviDeCroock Mar 1, 2020

kitten Mar 1, 2020

parkerziegler Mar 1, 2020

JoviDeCroock Mar 1, 2020

kitten Mar 1, 2020

parkerziegler Mar 1, 2020

		@@ -0,0 +1,25 @@
		# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.

Move next-urql to monorepo #557

Move next-urql to monorepo #557

Conversation

parkerziegler commented Feb 28, 2020

changeset-bot bot commented Feb 28, 2020 • edited Loading

🦋 Changeset is good to go

parkerziegler commented Mar 1, 2020

JoviDeCroock left a comment

Choose a reason for hiding this comment

JoviDeCroock Mar 1, 2020

Choose a reason for hiding this comment

kitten Mar 1, 2020

Choose a reason for hiding this comment

parkerziegler Mar 1, 2020

Choose a reason for hiding this comment

JoviDeCroock Mar 1, 2020

Choose a reason for hiding this comment

kitten Mar 1, 2020

Choose a reason for hiding this comment

parkerziegler Mar 1, 2020

Choose a reason for hiding this comment

changeset-bot bot commented Feb 28, 2020 •

edited

Loading