refactor: retrieve contract address from Instantiated event #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ui-use-ink ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
AlexD10S
commented
Sep 25, 2025
| * @param nonce The nonce value | ||
| * @returns The contract address | ||
| */ | ||
| export function create1(deployer: string, nonce: number): Address { |
There was a problem hiding this comment.
Removed these functions as there is no need to keep them anymore.
AlexD10S
commented
Sep 25, 2025
| code: metadata?.json.source.contract_binary, | ||
| }, | ||
| }); | ||
| return onSuccess(result); |
There was a problem hiding this comment.
Same approach now for ink! v5 and ink! v6: get the address from the instantiated event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates contract deployment to retrieve the smart contract address directly from the
Instantiatedevent, following the same approach already used inpallet_contracts.Blocked: In draft because needs the changes in api-contract library to be merged: polkadot-js/api#6210Tested locally building the api-contract from polkadot-js/api#6210Closes #581 now that the contract address is fetched in the
Instantiatedevent.