Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Add better typing for extra_links config variable #1131

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

chrisjsewell
Copy link
Member

To detail all possible dict keys

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 85.94%. Comparing base (63e1169) to head (0cd5991).

Files Patch % Lines
sphinx_needs/directives/needflow.py 75.00% 2 Missing ⚠️
sphinx_needs/config.py 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1131      +/-   ##
==========================================
+ Coverage   85.90%   85.94%   +0.03%     
==========================================
  Files          56       56              
  Lines        6515     6537      +22     
==========================================
+ Hits         5597     5618      +21     
- Misses        918      919       +1     
Flag Coverage Δ
pytests 85.94% <91.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisjsewell chrisjsewell merged commit 166a0e3 into master Feb 28, 2024
18 checks passed
@chrisjsewell chrisjsewell deleted the add-link-options-type branch February 28, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants