feat: support cleaning up removed lagoonyml routes #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
cleanup-removed-ingress
branch
3 times, most recently
from
a6c52d6
to
e41b4df
Compare
shreddedbacon
force-pushed
the
cleanup-removed-ingress
branch
from
e41b4df
to
1a5ebff
Compare
shreddedbacon
commented
Oct 4, 2023
shreddedbacon
force-pushed
the
cleanup-removed-ingress
branch
9 times, most recently
from
d32ac9c
to
0b27115
Compare
…asier cleanups refactor: ignore autogenerated, there is a separate cleanup for those refactor: wording for cleanups refactor: additional changes refactor: move cleanup into configuration step to ensure removed routes are removed from envvars
shreddedbacon
force-pushed
the
cleanup-removed-ingress
branch
from
0b27115
to
519f535
Compare
|
I'd like to get this one updated after #255 is merged, so that this could use the warnings system to call out if routes could be removed, and the actions the user could take to clean them up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for removed routes in .lagoon.yml and Lagoon API to be removed from the namespace.
This is feature flag wrapped for the moment, and will indicate in a build step if any actions would be performed if it detects any that would be removed.
Eventually this flag should be deprecated and cleanups should occur normally during a build
To enable it per project/environment, add the following variable as a GLOBAL scope
It can also be enabled at the cluster level by setting in the remote-controller
It also has a label selector, so that if a route has been added manually, it can get a label
route.lagoon.sh/remove=falseso that this new build step will ignore it.This is how it appears in the log when it is in no-op mode
And in op mode