Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add API_HOST back to api, load harbor password from secret #101

Merged
merged 4 commits into from
Oct 2, 2020
Merged

add API_HOST back to api, load harbor password from secret #101

merged 4 commits into from
Oct 2, 2020

Conversation

Schnitzel
Copy link
Contributor

  • realized that the api actually needs API_HOST after all
  • harbor password is stored in a secret so we can load it from there.

@smlx
Copy link
Member

smlx commented Oct 1, 2020

Hey @Schnitzel I added API_HOST back already in #98

@Schnitzel
Copy link
Contributor Author

Hey @Schnitzel I added API_HOST back already in #98

yep, sorry saw your PR after I pushed this already, will update this

smlx
smlx previously approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@smlx smlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We probably shouldn't be generating this value in the secret though, because it is configured in the external harbor service. I need to go back and review those generated values.

@smlx smlx merged commit 5b88281 into main Oct 2, 2020
@smlx smlx deleted the api-env-variables branch October 2, 2020 08:01
@smlx smlx mentioned this pull request Oct 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlx smlx smlx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Schnitzel @smlx