Feature: List Project Groups functionality #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
requested changes
Dec 4, 2023
sjerdo
reviewed
Dec 6, 2023
| handleError(err) | ||
|
|
||
| if len(projectGroups.Groups) == 0 { | ||
| output.RenderInfo(fmt.Sprintf("There are no projects in group '%s'", groupName), outputOptions) |
There was a problem hiding this comment.
Where is groupName defined? This message is confusing. I expect this message to be like "There are no groups for project '%s'" with the cmdProjectName as substitute
There was a problem hiding this comment.
Based on the condition though, this shouldn't ever be reached as projects should always have 1 group. Did you encounter this error?
There was a problem hiding this comment.
Yeah I get this error message for all of our projects. We haven't assigned our projects to a group yet.
~ % lagoon list project-groups -p <PROJECT NAME>
Info: There are no projects in group ''
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Adds the functionality to the CLI to list groups associated to a specified project.
Currently utilizing & pending merge of machinery PR uselagoon/machinery#23