Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Updated AddNotifications to utilize machinery #307

Merged
merged 5 commits into from
Dec 27, 2023
Merged

Improvement: Updated AddNotifications to utilize machinery #307

merged 5 commits into from
Dec 27, 2023

Conversation

CGoodwin90
Copy link
Contributor

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Updated all AddNotifications commands to utilize machinery.

Requires: uselagoon/machinery#32

@CGoodwin90 CGoodwin90 marked this pull request as ready for review December 15, 2023 03:37
shreddedbacon
shreddedbacon requested changes Dec 27, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
shreddedbacon
shreddedbacon approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! :shipit:

@shreddedbacon shreddedbacon merged commit 2291443 into main Dec 27, 2023
4 checks passed
@shreddedbacon shreddedbacon deleted the update-addnotifications branch December 27, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreddedbacon shreddedbacon shreddedbacon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CGoodwin90 @shreddedbacon