Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace tablewriter with go-pretty #314

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Jan 3, 2024

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Removes the need for having the forked tablewriter output. go-pretty does all the same stuff, and some of it is done better than tablewriter. It also appears to be maintained more than tablewriter is.

Output wise, the tables look identical

# tablewriter
$ lagoon -l local list projects
ID 	PROJECTNAME    	GITURL                                                   	PRODUCTIONENVIRONMENT	DEVENVIRONMENTS 
18 	lagoon-demo    	ssh://git@example.com/lagoon-demo.git                    	main                 	3/5	
180	lagoon-demo-org	ssh://git@example.com/lagoon-demo-org.git                	main                 	3/5

# go-pretty
$ go run main.go -l local list projects
ID 	PROJECTNAME    	GITURL                                                   	PRODUCTIONENVIRONMENT	DEVENVIRONMENTS
18 	lagoon-demo    	ssh://git@example.com/lagoon-demo.git                    	main                 	3/5
180	lagoon-demo-org	ssh://git@example.com/lagoon-demo-org.git                	main                 	3/5

Changelog Entry

@shreddedbacon shreddedbacon marked this pull request as ready for review January 3, 2024 07:09
@shreddedbacon shreddedbacon force-pushed the change-table-output branch 2 times, most recently from 2bca1e7 to e62cace Compare January 3, 2024 08:55
@shreddedbacon shreddedbacon merged commit 5b46da6 into main Jan 4, 2024
4 checks passed
@shreddedbacon shreddedbacon deleted the change-table-output branch January 4, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant