Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: strip existing project when adding it to an organization #3726

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

shreddedbacon
Copy link
Member

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

There exists a condition when adding an existing project to an organization that could result in a project and any groups it has being left in a disconnected state. This refactor is to make sure that the project and any access it previously had is stripped entirely when adding the project to the organization. Effectively it would appear as a fresh project (still retaining all of its environments etc. though)

@shreddedbacon shreddedbacon added this to the 2.20.0 milestone May 20, 2024
@shreddedbacon shreddedbacon marked this pull request as ready for review June 5, 2024 22:28
@shreddedbacon shreddedbacon force-pushed the refactor-add-existing-project-to-org branch from 6566383 to e961cef Compare June 26, 2024 06:07
@shreddedbacon shreddedbacon force-pushed the refactor-add-existing-project-to-org branch from e961cef to 0bf18e1 Compare June 26, 2024 06:30
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really neat - great work getting this in

@tobybellwood tobybellwood merged commit 5637896 into main Jun 26, 2024
1 check passed
@shreddedbacon shreddedbacon deleted the refactor-add-existing-project-to-org branch June 26, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants