Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to change survey name on 6th survey #1314

Closed
jshorland opened this issue Jul 26, 2016 · 20 comments
Closed

Unable to change survey name on 6th survey #1314

jshorland opened this issue Jul 26, 2016 · 20 comments
Assignees

Comments

@jshorland
Copy link

jshorland commented Jul 26, 2016

From grassroots user adviceni.ushahidi.io

"I’ve been creating the surveys and putting all the fields in under one task – you’re right, it makes it much easier for the user. It worked well for the 1st 5 surveys. However from 6 on when I create a new survey it won’t let me change the name of the first task which it automatically creates and calls “post” and it won’t let me delete it so I have to add a 2nd task. I’m not sure why it’s doing this and how I can fix it. If you look at our deployment you can see that it starts to go wrong with the “Sure Start Maternity Grant (unable to apply for 2nd subsequent child) Benefits” survey.

@willdoran would you mind taking a look into this when you have a chance?

@jshorland
Copy link
Author

@willdoran
Copy link
Contributor

hey @jshorland the default task "Post" is fixed and can't be renamed, I believe this is an intentional UI design. Do we want to change this to make the task renameable?

@jshorland
Copy link
Author

I double checked with the user, and she says she was able to change the first task from Post to a custom title, but wasn't able to do the same at the 4th or 5th survey she created. I've asked her to give me admin privileges to confirm this.

@willdoran
Copy link
Contributor

thanks! Hmm that is very strange

@jshorland
Copy link
Author

I was also able to change the first task's title in quakemap.ushahidi.io

@willdoran
Copy link
Contributor

Super weird, I'll test it here

@willdoran
Copy link
Contributor

Hmmm, I can't edit on my local or on my ushahididev.com instance. Were you able to edit it directly in the text box? Did you save first?

@jshorland
Copy link
Author

Update: the surveys on which she was able to edit the name of the first task were from her deployment pre-mustang. Surveys she's now creating post-mustang migration do NOT allow for changing first task name from "post". @brandonrosage do you mind reminding me of the thinking behind this?

@brandonrosage
Copy link

Short answer: In a world where Ushahidi allows "free-form" tasks, all task names should be editable.

Slightly longer answer: The rollout of Mustang first offered a model for Tasks that was more "choose from these pre-built tasks." And that's where fixed task names originated. The constraints of the release led to this semi-clumsy hybrid.

I'm seeing editable task names across the board on my demo deployment, though. So I'm not clear what the issue is with the current client.

@jshorland
Copy link
Author

@brandon that's because those are surveys you created prior to mustang that retained that edit able quality in migration.

Try to create a new survey and edit the first pre-loaded task name to replicate the issue. It's presented a bit of confusion for pre-mustang users and requests for custom names from new users.

I'd suggest we make all tasks editable.

Sent from my iPhone

On Jul 27, 2016, at 7:30 AM, Brandon Rosage notifications@github.com wrote:

Short answer: In a world where Ushahidi allows "free-form" tasks, all task names should be editable.

Slightly longer answer: The rollout of Mustang first offered a model for Tasks that was more "choose from these pre-built tasks." And that's where fixed task names originated. The constraints of the release led to this semi-clumsy hybrid.

I'm seeing editable task names across the board on my demo deployment, though. So I'm not clear what the issue is with the current client.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@brandonrosage
Copy link

brandonrosage commented Jul 27, 2016

Oh, I see. It's presented as a field, so I assumed I could change it. Of course, it's disabled. Yeah, that needs to be editable in a "free-form" model.

@willdoran
Copy link
Contributor

@brandonrosage @jshorland I will change this to allow users to edit all tasks - @brandonrosage, all tasks should thus be reorderable, yes? At present the fixed "Post" task is not.

@jshorland
Copy link
Author

@willdoran yes, all tasks should be re-orderable as well.

@rjmackay
Copy link
Contributor

rjmackay commented Aug 7, 2016

@willdoran yes, all tasks should be re-orderable as well.

Wait... With the split of Post fields from Task fields I don't think we should treat 'Post' as a task at all. I think this need to loop back to design because this design doesn't have UI to reorder tasks at all.

@brandonrosage
Copy link

Two things to resolve here:

  1. The process and timing for the build-out of Tasks. My understanding was that we'd finish staging a design solution in the PL before the next sprint planning meeting (which launches the client implementation). So while I have a solution for this, I've been careful not roll it out until it had been more thoroughly reviewed.
  2. The solution to this point does provide, A, separation between "Post fields" and "Task fields", and B, UI for re-ordering a survey's tasks.

Example:
Tasks

I'd appreciate some clarity, @rjmackay and @jshorland, on how I can best time the staging of all this so design is not at all a bottleneck for the implementation of this feature.

@jshorland
Copy link
Author

Sorry for my delay here. @brandonrosage we won't be able to start implementing tasks until after hit team. I'll have a more detailed schedule based on recent issues submitted into out github by wednesday of this week. Is there more clarity you'll need beyond timing for tasks?

@brandonrosage
Copy link

Just a shared understanding of how it'll work (I've outlined a solution) and the deadlines for each phase of work on the epic.

@rjmackay
Copy link
Contributor

rjmackay commented Sep 6, 2016

Assigned to @jshorland for QA since this is probably solved in last sprint

@jshorland
Copy link
Author

jshorland commented Sep 23, 2016

@brandonrosage correct me if I'm wrong, that while we did address the tasking issue, there's still an issue of "title" and "description" being un-editable. but that wasn't exactly what this was about and really gets addressed in free-form survey build also addressing #1335

@brandonrosage
Copy link

@jshorland Spot on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants