-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Hard-Coded Logic in Filetype Extension Conversion Script for Pipeline #1301
Fix Hard-Coded Logic in Filetype Extension Conversion Script for Pipeline #1301
Conversation
a243ddb
to
f80d7b4
Compare
Talked with Dave and will document evidence of in-place testing but not embed tests inline or separately add them and invoke them if we will not execute them as mandatory in CI/CD. Setting up CI/CD script testing and hardness would be a big lift to get it right. |
Woops, it took a lot of CI/CD tweaks to confirm this was working on my fork and I couldn't figure out the weird errors in the GHA itself for the auto-commit features (it doesn't work well on forks). Finally, here is a reviewable example that the tweaks worked. |
Committer Notes
Closes usnistgov/oscal-content#109, with explanation in usnistgov/oscal-content#109 (comment).
All Submissions:
"?
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
Changes to Core Features:
Have you written new tests for your core changes, as applicable?Have you included examples of how to use your new feature(s)?Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.