Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hard-Coded Logic in Filetype Extension Conversion Script for Pipeline #1301

Conversation

aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented Jun 8, 2022

Committer Notes

Closes usnistgov/oscal-content#109, with explanation in usnistgov/oscal-content#109 (comment).

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@aj-stein-nist aj-stein-nist added bug Scope: CI/CD Enhancements to the project's Continuous Integration and Continuous Delivery pipeline. Developer Experience Issues around enhancing and optimizing work for development of NIST OSCAL artifacts labels Jun 8, 2022
@aj-stein-nist aj-stein-nist self-assigned this Jun 8, 2022
@aj-stein-nist aj-stein-nist force-pushed the 109-rev-5-baselines-reference-xml-version-of-the-catalog branch from a243ddb to f80d7b4 Compare June 8, 2022 04:32
@aj-stein-nist aj-stein-nist added this to the OSCAL 1.0.5 milestone Jun 8, 2022
@aj-stein-nist
Copy link
Contributor Author

Talked with Dave and will document evidence of in-place testing but not embed tests inline or separately add them and invoke them if we will not execute them as mandatory in CI/CD. Setting up CI/CD script testing and hardness would be a big lift to get it right.

aj-stein-nist added a commit to aj-stein-nist/oscal-content-forked that referenced this pull request Jun 10, 2022
@aj-stein-nist aj-stein-nist marked this pull request as ready for review June 10, 2022 22:00
aj-stein-nist added a commit to aj-stein-nist/oscal-content-forked that referenced this pull request Jun 10, 2022
aj-stein-nist added a commit to aj-stein-nist/oscal-content-forked that referenced this pull request Jun 13, 2022
@aj-stein-nist
Copy link
Contributor Author

Woops, it took a lot of CI/CD tweaks to confirm this was working on my fork and I couldn't figure out the weird errors in the GHA itself for the auto-commit features (it doesn't work well on forks). Finally, here is a reviewable example that the tweaks worked.

https://github.com/aj-stein-nist/oscal-content/pull/1/files#diff-a3a508d3ee6d8007468e74ec6373df31844335c1b59db656872264a04b3cf53a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Developer Experience Issues around enhancing and optimizing work for development of NIST OSCAL artifacts Scope: CI/CD Enhancements to the project's Continuous Integration and Continuous Delivery pipeline.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rev 5 Baselines Reference XML Version of the Catalog
2 participants