Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 800-53 JSON examples #195

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Update 800-53 JSON examples #195

merged 1 commit into from
Jul 26, 2018

Conversation

anweiss
Copy link
Contributor

@anweiss anweiss commented May 30, 2018

Committer Notes

To address #197, this includes updated JSON examples based on the latest data models in master and that which are equivalent to the 800-53 XML examples in the examples/SP800-53 directory.

Updates to oscalkit to reflect the latest data model are being tracked at docker-archive/oscalkit#1.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?

@anweiss anweiss force-pushed the json branch 3 times, most recently from ce6505a to 8160947 Compare May 30, 2018 20:38
@anweiss
Copy link
Contributor Author

anweiss commented May 30, 2018

This PR is dependent on #143 so equivalent JSON examples can be generated.

@anweiss anweiss force-pushed the json branch 2 times, most recently from 363393d to c2577e0 Compare June 4, 2018 17:01
@anweiss
Copy link
Contributor Author

anweiss commented Jun 4, 2018

800-53 catalog, declarations and profile examples have been pushed. Waiting for FedRAMP profile cleanup to re-generate JSON equivalents.

@JJediny
Copy link

JJediny commented Jun 5, 2018

@anweiss this LGTM, is it worth breaking out the FEDRAMP update as another PR when ready and merge this first?

@anweiss
Copy link
Contributor Author

anweiss commented Jun 5, 2018

@JJediny yea good idea. Will commit FedRAMP examples in another PR

@anweiss anweiss changed the title [WIP] Update JSON schemas to reflect latest data model and include updated JSON examples [WIP] Update JSON examples Jun 7, 2018
@anweiss anweiss force-pushed the json branch 2 times, most recently from a33485a to 07f7c03 Compare June 7, 2018 20:23
@anweiss anweiss changed the title [WIP] Update JSON examples Update 800-53 JSON examples Jun 8, 2018
@david-waltermire
Copy link
Contributor

Regarding #197, this PR contains updated 800-53 examples. Another PR will be submitted for the FedRAMP examples once #185 is resolved. We need to validate the JSON content against the latest Metaschema generated JSON Schema, before accepting this PR. Also need to validate the XML content.

Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples appear accurate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants