Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring index constraints #102

Merged

Conversation

david-waltermire
Copy link
Collaborator

Committer Notes

  • Refactored index constraints to use the new IIndex class. This will help in the future with further enhancements around use of indexes.
  • Added and integrated a ConstraintValidationFinding builder for generating new findings.
  • Improved error handling to emit validation errors instead of exceptions. This will result in the reporting of index lookup misses as findings.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

…elp in the future with further enhancements around use of indexes.

Added and integrated a ConstraintValidationFinding builder for generating new findings.
Improved error handling to emit validation errors instead of exceptions.
@david-waltermire david-waltermire changed the title Refactored index constraints to use the new IIndex class. This will h… Refactoring index constraints Aug 20, 2022
@david-waltermire david-waltermire merged commit e3a1ae6 into usnistgov:develop Aug 20, 2022
@david-waltermire david-waltermire deleted the refactor-index-constraints branch August 20, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant