Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify title lookup function #661

Merged

Conversation

zakpatterson
Copy link
Collaborator

What kind of change does this PR introduce? (delete not applicable)

  • Code style update
  • Refactor

@zakpatterson zakpatterson force-pushed the refactor-simplify-title-finding-function branch from 599bed6 to 9273f67 Compare October 19, 2021 15:46
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2021

Codecov Report

Merging #661 (9273f67) into master (9bcefa2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #661   +/-   ##
=======================================
  Coverage   64.20%   64.21%           
=======================================
  Files         108      108           
  Lines        3716     3711    -5     
  Branches      573      571    -2     
=======================================
- Hits         2386     2383    -3     
+ Misses       1315     1313    -2     
  Partials       15       15           
Impacted Files Coverage Δ
src/components/Menu.tsx 93.33% <100.00%> (+13.33%) ⬆️
src/irsForms/ScheduleEIC.ts 77.65% <0.00%> (-1.12%) ⬇️
src/irsForms/worksheets/ChildTaxCreditWorksheet.ts 100.00% <0.00%> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bcefa2...9273f67. Read the comment docs.

Copy link
Collaborator

@thegrims thegrims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thegrims thegrims merged commit 2a79912 into ustaxes:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants