Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public-Sans: Update Ruby and Node versions #309

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

mahoneycm
Copy link
Contributor

@mahoneycm mahoneycm commented Jul 19, 2024

Summary

Updated defined Node and Ruby versions of the repo.

Related issue

Closes #307

Preview link

Public-sans →

Problem statement

Newer versions of Ruby and Node are used for improved features and security.

Solution

  1. Update .nvrmc to latest LTS version - 20.15.1
  2. Update .ruby-version to the latest version that's in normal maintenance.
  3. Run gem install bundler to confirm relevant version of the bundler is installed.

Testing and review

  1. Update your local node version
    1. nvm install 20.15.1
    2. nvm use 20
  2. Update your local ruby version
    1. rvm install 3.3.4 -- --with-openssl-dir=$(brew --prefix openssl@1.1)
    2. rvm use 3.3.4
  3. Run npm install and confirm there are no errors
  4. Run bundle install and confirm there are no errors
  5. Run npm run build start and confirm there are no errors
  6. Run npm run serve and confirm site builds as expected
  7. Look at tool versions (listed below) and confirm version decisions

Tool release schedules

Node releases →
Ruby maintenance branches ->

@mahoneycm mahoneycm changed the base branch from develop to cm-POAM-july-2024 July 19, 2024 20:17
@mahoneycm mahoneycm requested a review from mejiaj July 19, 2024 20:18
Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this! Minor suggestion, otherwise looks good. No issues following test commends (the npm run build task runs pretty long).

I see that the target branch is cm-POAM-july-2024 was that intentional? Just want to make sure.

.nvmrc Outdated Show resolved Hide resolved
Co-authored-by: James Mejia <james.mejia@gsa.gov>
@mahoneycm
Copy link
Contributor Author

@mejiaj sounds good! Committed your suggestion 👍

And yes, I was hoping to include this with the POAM updates so I set it as the target branch. Happy to change if need be but this was branched off of the POAM updates so the node_modules would be up to date

@mejiaj mejiaj self-requested a review July 22, 2024 14:25
Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Charlie.

@mejiaj mejiaj merged commit c10ff77 into cm-POAM-july-2024 Jul 22, 2024
1 check passed
@mejiaj mejiaj deleted the cm-update-node-and-ruby branch July 22, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public Sans - Feature: Update ruby & node version
2 participants