Skip to content

Refactor answer of exercise of login #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

chvmvd
Copy link
Contributor

@chvmvd chvmvd commented Dec 7, 2023

No description provided.

@chvmvd chvmvd marked this pull request as ready for review December 7, 2023 07:56
@chvmvd chvmvd requested a review from aster-void December 7, 2023 07:56
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5fa0130
Status: ✅  Deploy successful!
Preview URL: https://df1adc83.utcode-learn.pages.dev
Branch Preview URL: https://refactor-login-exercise-answ.utcode-learn.pages.dev

View logs

@@ -117,7 +117,7 @@ app.listen(3000);
このページの URL を見てみましょう。特に、クエリパラメータの部分に注目してみましょう。
![URLのクエリパラメータ](form-url.png)

## 課題1
## 初級課題
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

初級と言うほど簡単でもないような...
初級課題はもっと確認問題的な余計な要素がないものの方がいいと思います

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

そうなんですよね...
ちょっとこれむずいよな...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

中級課題よりは簡単なので、とりあえずは初級課題でもいいのかなあという気はします。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

じゃあ今度確認問題を追加しておきます 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

今の初級課題はもう消しても良いかもね。

@chvmvd chvmvd requested a review from aster-void January 23, 2024 04:40
Copy link
Contributor

@aster-void aster-void left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chvmvd chvmvd merged commit 2404749 into master Jan 23, 2024
@chvmvd chvmvd deleted the refactor-login-exercise-answer branch January 23, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants