-
Notifications
You must be signed in to change notification settings - Fork 3
Dateクラスの演習を書き換えました #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dateクラスの演習を書き換えました #755
Conversation
Deploying utcode-learn with
|
Latest commit: |
e15cafc
|
Status: | ✅ Deploy successful! |
Preview URL: | https://848f98c2.utcode-learn.pages.dev |
Branch Preview URL: | https://class-exercise-change.utcode-learn.pages.dev |
@@ -5,7 +5,7 @@ | |||
<title>カウントダウン</title> | |||
</head> | |||
<body> | |||
<div id="countdown-box"></div> | |||
<div id="crrent-time"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
u抜けてますね。
@@ -282,7 +282,7 @@ tanaka.introduceSelf(); // 私の名前は田中です。18歳です。ドイツ | |||
|
|||
`Student` クラスを継承して `SeniorStudent` クラスを作ってみましょう。`SeniorStudent` クラスのインスタンスは `researchQuestion` プロパティを持ち、`introduceSelf` メソッドを実行すると自分の名前を出力した後に自分の研究内容を紹介するようにしてみましょう。 | |||
|
|||
<Answer title="学生のClassの定義"> | |||
<Answer title="先輩学生の自己紹介"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
先輩というより高学年?じゃないでしょうか。
@@ -342,7 +342,7 @@ document.write(myBirthDay.getFullYear()); // 2014 | |||
{/* TODO: 自分はこっちのほうがいいと思いますが... | |||
例えば [`Map` クラス](https://developer.mozilla.org/ja/docs/Web/JavaScript/Reference/Global_Objects/Map)は、キーと値のペアを保存するオブジェクトを提供します。 | |||
|
|||
```js | |||
```javascript |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
コンフリクトしそうです。解決頑張ってください。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
今なんかありましたっけ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここのコメントを別ブランチで @kiyokaanan さんが消してました。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
そこか。
@@ -0,0 +1,15 @@ | |||
const CurrentTime = document.getElementById("current-time"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CurrentTime
でなくて、currentTime
かな。キャメルケースで。
``` | ||
|
||
と表示する | ||
[`Date` クラス](https://developer.mozilla.org/ja/docs/Web/JavaScript/Reference/Global_Objects/Date)を使って、現在時刻を表示してみましょう。[`Date` クラス](https://developer.mozilla.org/ja/docs/Web/JavaScript/Reference/Global_Objects/Date)のドキュメントを読んで、現在時刻を表示するのに必要なメソッドを探してみましょう。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
リンクつけるのは最初の1回だけで良さそう。
return `今は${currentYear}年${currentMonth}月${currentDate}日${currentHour}時${currentMinute}分${currentSecond}秒です。`; | ||
} | ||
|
||
CurrentTime.textContent = getCurrentTime(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここも。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -2,10 +2,10 @@ | |||
<html lang="ja"> | |||
<head> | |||
<meta charset="utf-8" /> | |||
<title>カウントダウン</title> | |||
<title>現在時刻</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
細かいこと言うとここら辺を他と合わせて「〇〇の解答例」としたかったりします。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これに関しては全体として方針をちゃんと決めていないのと、僕は逆にこのままの方が良いと思っているので一旦放置で良いんじゃないでしょうか。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.