Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support shell scripts for mulitple unix dialects (especially for macOS) #796

Closed
PhilippSalvisberg opened this issue Nov 24, 2018 · 0 comments
Closed

Comments

@PhilippSalvisberg
Copy link
Member

@PhilippSalvisberg PhilippSalvisberg commented Nov 24, 2018

The following v3.1.3 files use sed -r which is not supported under macOS and FreeBDS (sed -E has to be used instead):

  • utPLSQL/.travis/get_project_build_version.sh
  • utPLSQL/.travis/get_project_version.sh
  • utPLSQL/test/install_and_run_tests.sh

Based on the discussion in Slack these sed calls are not required anymore.

It would be great if the shell scripts could be changed, so that they run unchanged under macOS.

jgebal added a commit that referenced this issue Nov 24, 2018
Changed `sed -r` to `sed -E`
Resolves #796
@jgebal jgebal closed this in #797 Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant