test_walk_1_real_robot fixes
#720
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
acrylic-origami
commented
Dec 2, 2022
acrylic-origami
commented
- Only the minimal change is included in this PR the commits are kept minimal
- Code is readable and documented in the code
- Minimal tests have been added
|
You need to put the skip back in to pass CI |
Vuwij
approved these changes
Dec 2, 2022
Vuwij
reviewed
Dec 6, 2022
| @@ -32,6 +32,7 @@ def walker(request) -> Navigator: | |||
| config_folder_path = f"{file_path}/../../config/" | |||
| config_path = config_folder_path + f"{robot_model}_sim_pybullet.yaml" | |||
| set_rosparam_from_yaml_file(param_path=config_path) | |||
| set_rosparam_from_yaml_file(param_path=f"{file_path}/../../../{robot_model}_description/config/motor_mapping.yaml") | |||
There was a problem hiding this comment.
and then put the rospy.wait_for_message into this
|
Stale pull request message |
|
Stale pull request message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.