Changing ErrMode::Cut to ErrMode::Backtrack to allow alt parser flow (Fix for uutils/coreutils issue 8754) #238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR purposes changes that fix uutils/coreutils#8754 after a chore in coreutils to move from parse_datetime v0.11.0 to the latest including this fix.
Summary:
ErrMode::Cut(e)
withErrMode::BackTrack(e)
within date items parser functions to enable alternate parser flow to continue instead of failing prematurely.Details:
ErrMode::Cut(e)
within a parser it signals that the error is not recoverable and the parser chain unwinds and fails. In some cases this is desirable but for the parser functions in date it seems they are recoverable errors.Testing notes: