-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doctr deploy #64
doctr deploy #64
Conversation
Sorry. I made a conflict. Could you please rebase? |
Also -- it would be good to add a bit of documentation explaining what is going on here (in the README). For example, I am not sure what I am supposed to do to generate a Github API token, and where I am supposed to put it 😄 |
Also, also: thanks for doing this! |
did you get rid of the build matrix? That looks like where the conflict is, but it seems that it was totally removed? |
ya but that used to be a big ol' matrix thing with a bunch of explicit environment variables etc...generally doctr would only deploy within one of the builds (the one with python 3) but I'm not sure how to add extra commands to a build if they are only specified w/ a list of 3 strings. |
Oh - sorry about that. This seems more civilized though. How about a bash if statement in the |
Cool - sounds good, lemme look into this once I get a little bit of extra bandwidth :-) |
ok I thought about this a bit and I think I know the best way to do it. However it entails adding a post-success shell script because travis handles multi-line statements strangely. Is that OK w/ you? So basically the PR would add two things:
wdyt? |
mmmk...let's see if the latest push works :-) |
eff1bde
to
83bc7a7
Compare
Looks like it works! Thanks for doing this. Any chance you could add some documentation to the README, explaining what this is, and how to use it? |
One more question: this builds the documentation on every merge, is that correct? How do you handle docs for release version, versus the docs for current master? |
I'll update the readme for sure! And yep, it's mostly meant for devdocs versions of documentation. For releases, I think right now something like RTD is still best since it naturally handles multiple versions of things etc. doctr just ensures that the public-facing docs on master are always available. Maybe we can chat about the best way to integrate this w/ shablona since (in my mind anyway) this repo is designed to be a demonstration of best practices. WDYT? |
H/T to @choldgraf for figuring this out over on uwescience/shablona#64
Hey! We should pick this thread back up. I still think we want a doctr deploy into Github pages. I have a new idea: what if doctr deployed the development docs to another repo (something like I am experimenting with all this over on popylar/popylar and popylar/popylar-dev-docs. |
yo - sounds good! Just got back from England this week and slowly getting caught up. I think what you describe is possible with |
Heyyyyy. Did somebody say "stale PR"? :-) I've been thinking about this a little bit, and I am not so sure that we want to recommend "doctr" as a part of documentation for "beginner-level" developers. I think doctr is super useful, but still falls into the category of "but try getting as far as you can with ReadTheDocs first". Perhaps that means we shouldn't recommend or use it here, and instead mention / link out to it? What I'd propose is the following:
what do you think? |
@arokem since he's probably written this PR off as dead :-D |
That all sounds good. To be completely honest, I am thinking of moving away from the shablona way of doing things. The combination of the recent scipy packaging tutorial and the scientific python cookiecutter have made me question whether this really is the best way to do things, even for beginners. But I am not sure whether/what actions to take here. |
whoah that tutorial looks awesome! For the cookiecutter, have you used it? Do you think it's a good drop-in for Shablona? I'm going to close this PR now. If you think a docs PR for this repo is still useful let me know |
Yeah - it's pretty good, but might not be suitable for beginners. For example, it does show how to use doctr. Here's me teaching a group at NeuroHackademy about packaging using this cookie-cutter (and their awesome documentation). |
OK this should be the right configuration so that doctr deploys the latest documentation on
gh-pages
. If this all looks good, you should open a PR that inserts your own github API token (or whatever account "controls" shablona). See the docs example at http://predictablynoisy.com/shablona