Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Salt API endpoint authenticated and encrypted #2613

Merged
merged 8 commits into from
Sep 16, 2020

Conversation

moio
Copy link
Contributor

@moio moio commented Sep 16, 2020

What does this PR change?

Makes the salt API endpoint authenticated and encrypted.

Addresses CVE-2020-8028, aka SUSE bug number 1175884

GUI diff

No difference.

Documentation

No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Links

Fixes https://bugzilla.suse.com/show_bug.cgi?id=1175884
Tracks https://github.com/SUSE/spacewalk/pull/12276

  • DONE

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_lint_checkstyle"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_oracle"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Copy link
Member

@juliogonzalez juliogonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for the tests.

@juliogonzalez
Copy link
Member

The failed test is expected, as for other PRs. Nothing to worry about.

@juliogonzalez juliogonzalez merged commit 9d6aa98 into Uyuni-2020.07 Sep 16, 2020
@juliogonzalez juliogonzalez deleted the authenticated-salt-api branch September 16, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants