Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove session timeout from webapp, in order to use the persisted one in /etc/tomcat/web.xml #9102

Merged

Conversation

mbussolotto
Copy link
Member

@mbussolotto mbussolotto commented Jul 25, 2024

What does this PR change?

remove session timeout from webapp, in order to use the persisted one in /etc/tomcat/web.xml: this would allow to tune it as described https://www.uyuni-project.org/uyuni-docs/en/uyuni/administration/troubleshooting/tshoot-logintimeout.html

GUI diff

No difference.

  • DONE

Documentation

  • Doc needs to be changed from /usr/share/susemanager/www/tomcat/webapps/rhn/WEB-INF/web.xml to /etc/tomcat/web.xml

  • DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • No tests

  • DONE

Links

Issue(s): #8030

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9102/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9102/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@mbussolotto mbussolotto linked an issue Jul 25, 2024 that may be closed by this pull request
@mbussolotto mbussolotto marked this pull request as ready for review July 25, 2024 09:46
@mbussolotto mbussolotto requested a review from a team as a code owner July 25, 2024 09:46
@mbussolotto mbussolotto requested review from rjpmestre and removed request for a team July 25, 2024 09:46
@mbussolotto mbussolotto requested a review from aaannz July 25, 2024 09:52
@mbussolotto mbussolotto added merge-candidate Meaning it needs to be considered for merging when the master branch is frozen ready PR ready, waiting branch is unlocked labels Jul 29, 2024
@deneb-alpha deneb-alpha merged commit aaeb960 into uyuni-project:master Sep 9, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java_lint_checkstyle java_pgsql_tests java merge-candidate Meaning it needs to be considered for merging when the master branch is frozen ready PR ready, waiting branch is unlocked webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in web.xml are not persisted in Uyuni Container
4 participants