Skip to content

fix: Fix release signing configuration for CI/CD #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025
Merged

fix: Fix release signing configuration for CI/CD #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,16 @@ android {
storePassword GHUI_KEYSTORE_PASSWORD
keyAlias project.hasProperty("GHUI_KEY_ALIAS") ? GHUI_KEY_ALIAS : "ghui"
keyPassword GHUI_KEY_PASSWORD
} else if (project.hasProperty("GHUI_KEYSTORE_PASSWORD") && project.hasProperty("GHUI_KEY_PASSWORD")) {
// CI/CD environment but keystore file might not exist yet
// This prevents the build from failing during configuration phase
storeFile file("keystore.jks")
storePassword GHUI_KEYSTORE_PASSWORD
keyAlias project.hasProperty("GHUI_KEY_ALIAS") ? GHUI_KEY_ALIAS : "ghui"
keyPassword GHUI_KEY_PASSWORD
} else {
// For local builds without proper signing setup, use debug signing
def debugSigningConfig = android.signingConfigs.debug
storeFile debugSigningConfig.storeFile
storePassword debugSigningConfig.storePassword
keyAlias debugSigningConfig.keyAlias
keyPassword debugSigningConfig.keyPassword
// For local builds without proper signing setup, throw an error
throw new GradleException("Release builds require signing configuration. Please provide GHUI_KEYSTORE_PASSWORD and GHUI_KEY_PASSWORD.")
}
}
}
Expand Down
Loading