Fix crash when clicking Ignore/Report without login #42
Conversation
Added login checks for all user actions in FeedDetail: - Star/Unstar topic - Thanks author - Ignore topic - Report topic - Reply to topic These actions now: 1. Check if user is logged in before executing 2. Show login prompt if not authenticated 3. Properly handle nil values with guard statements 4. Show error messages if required data is missing This fixes the crash reported in issue #4 when non-logged-in users click Ignore or Report buttons. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical crash issue when non-authenticated users attempt to perform actions (Ignore/Report/Star/Thanks/Reply) in the FeedDetail view. The fix adds proper login status validation and replaces unsafe force unwrapping with safe guard statements to prevent nil pointer crashes.
- Added authentication checks using
AccountState.hasSignIn()before executing user actions - Replaced force unwrapping operators (
!) with safeguardstatements and proper error handling - Shows appropriate login prompts with contextual messages when unauthenticated users attempt actions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| Toast.show("请先登录") | ||
| dispatch(LoginActions.ShowLoginPageAction(reason: "需要登录才能收藏主题")) |
There was a problem hiding this comment.
The login prompt logic is duplicated across all actions. Consider extracting this into a shared helper method to reduce code duplication and improve maintainability.
Copilot uses AI. Check for mistakes.
| Toast.show(hadStared ? "取消收藏" : "收藏中") | ||
| let once = state?.model.once | ||
| guard let once = state?.model.once else { | ||
| Toast.show("操作失败，请刷新页面") |
There was a problem hiding this comment.
The error message '操作失败，请刷新页面' is duplicated multiple times. Consider defining this as a constant to ensure consistency and easier maintenance.
Copilot uses AI. Check for mistakes.
Code Coverage Report ❌Current coverage: 0% |
Summary
Changes Made
AccountState.hasSignIn()checks before executing user actions!) with safeguardstatementsAffected Actions
All the following actions now properly check authentication:
Test Plan
Fixes #4
🤖 Generated with Claude Code