Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: empty usage message with undefined flag (reopen) #2761

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

heimoshuiyu
Copy link
Contributor

Related issue: #2029
Last PR (closed): #2089

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f67e46c) 37.66% compared to head (17e3aae) 37.66%.

Files Patch % Lines
main/commands/base/execute.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2761      +/-   ##
==========================================
- Coverage   37.66%   37.66%   -0.01%     
==========================================
  Files         659      659              
  Lines       38892    38894       +2     
==========================================
- Hits        14649    14648       -1     
- Misses      22626    22629       +3     
  Partials     1617     1617              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@xiaokangwang xiaokangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. It is ready to be included in v5.12.0

@xiaokangwang xiaokangwang merged commit 5a96b37 into v2fly:master Nov 19, 2023
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants