Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put object to the vineyardd with the least memory usage while the connected one is out of memory #1807

Closed
dashanji opened this issue Mar 8, 2024 · 0 comments · Fixed by #1809
Labels
component:python Issues about vineyard's python SDK enhancement New feature or request

Comments

@dashanji
Copy link
Member

dashanji commented Mar 8, 2024

Describe your problem

When the connected vineyardd is out of memory, the client can't put anything in the vineyardd. However, in the k8s cluster, the memory of vineyardd cluster(e,g, 3 replicas) will not be maximally used.

To avoid this, we can improve the current put function:

  1. When the NotEnoughMemoryException occurs, we can find all vineyardd info via client.meta, then create multiple clients to connect all vineyardd servers. (for each vineyardd, connect via ipc firstly)
  2. Find the vineyardd with the least memory usage and put the object in it.
@dashanji dashanji added the enhancement New feature or request label Mar 8, 2024
@sighingnow sighingnow added the component:python Issues about vineyard's python SDK label Mar 8, 2024
sighingnow pushed a commit that referenced this issue Mar 11, 2024
…able memory (#1809)

Fixes #1807

Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python Issues about vineyard's python SDK enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants