Optimize the memory usage of string vertex map #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sighingnow
force-pushed
the
ht/vm-string-opt
branch
from
04addb9
to
ded9b4a
Compare
|
✅ Doc deploy preview ready: https://deploy-preview-pr-1151--v6d.netlify.app |
siyuan0322
approved these changes
Jan 12, 2023
sighingnow
force-pushed
the
ht/vm-string-opt
branch
3 times, most recently
from
80cf477
to
5ef7f4e
Compare
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
sighingnow
force-pushed
the
ht/vm-string-opt
branch
from
5ef7f4e
to
a2a18fa
Compare
sighingnow
added a commit
to alibaba/GraphScope
that referenced
this pull request
Jan 14, 2023
## What do these changes do?
- Expose the `retain_oid` options to Python
- Upgrade vineyard to latest version to handle the memory usage issues
- Adding `errors="ignore"` to avoid decoding/encoding errors
- Enable `int32_t` OID type support
## Benchmarking
Settings:
- 1 worker
- loading from CSV (710MB)
- nodes: 330MB, 21865475
- edges: 380MB, 11089373
- workload: loading (`generate_eid=False`) -> project -> pagerank
Memory usage:
- `int64_t` oid:
- `retain_oid=True`:
- after loading graph, peak: 3.53GB
- after project, peak: 3.72GB
- after running the application, peak: 4.49GB
- `retain_oid=False`:
- after loading graph, peak: 3.33GB
- after project, peak: 3.53GB
- after running the application, peak: 4.29GB
- `string` oid: graph: , peak:
- `retain_oid=True`:
- after loading graph, peak: 5.16GB
- after project, peak: 5.18GB
- after running the application, peak: 6.00GB
- `retain_oid=False`:
- after loading graph, peak: 4.68GB
- after project, peak: 4.70GB
- after running the application, peak: 5.51GB
## Related issue number
Fixes #2127
Fixes #2269
See also: v6d-io/v6d#1151
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
string_viewas the kyBufferOrEmpty()method to return valid shared pointers even the blob itself is emptyRelated issue number
N/A