Migrate SetAccessor uses to SetNativeDataProperty

.devcontainer/.devcontainer.json

@@ -0,0 +1,19 @@
+{
+  "name": "Node.js Core Developer Environment",
+  "extensions": [
+      "github.vscode-pull-request-github",
+      "ms-vsliveshare.vsliveshare",
+      "vscode-icons-team.vscode-icons",
+      "visualstudioexptteam.vscodeintellicode"
+  ],
+  "dockerFile": "Dockerfile",
+  "initializeCommand": "docker system prune -f -a",
+  "settings": {
+    "terminal.integrated.profiles.linux": {
+      "zsh (login)": {
+        "path": "zsh",
+        "args": ["-l"]
+      }
+    }
+  }
+}

.devcontainer/Dockerfile

@@ -0,0 +1 @@
+FROM nodejs/devcontainer:nightly

.eslintignore

@@ -5,6 +5,7 @@ test/fixtures
 test/message/esm_display_syntax_error.mjs
 tools/icu
 tools/lint-md/lint-md.mjs
+tools/github_reporter
 benchmark/tmp
 benchmark/fixtures
 doc/**/*.js

.eslintrc.js

@@ -68,7 +68,7 @@ module.exports = {
       files: ['**/*.md/*.cjs', '**/*.md/*.js'],
       parserOptions: {
         sourceType: 'script',
-        ecmaFeatures: { impliedStrict: true }
+        ecmaFeatures: { impliedStrict: true },
       },
       rules: { strict: 'off' },
     },
@@ -103,45 +103,46 @@ module.exports = {
         },
         {
           name: 'Buffer',
-          message: 'Import Buffer instead of using the global'
+          message: 'Import Buffer instead of using the global',
         },
         {
           name: 'process',
-          message: 'Import process instead of using the global'
+          message: 'Import process instead of using the global',
         },
       ] },
     },
+    {
+      files: [
+        'lib/internal/test_runner/**/*.js',
+      ],
+      rules: {
+        'node-core/set-proto-to-null-in-object': 'error',
+      },
+    },
   ],
   rules: {
     // ESLint built-in rules
     // https://eslint.org/docs/rules/
     'accessor-pairs': 'error',
     'array-callback-return': 'error',
-    'arrow-parens': ['error', 'always'],
-    'arrow-spacing': ['error', { before: true, after: true }],
+    'arrow-parens': 'error',
+    'arrow-spacing': 'error',
     'block-scoped-var': 'error',
     'block-spacing': 'error',
     'brace-style': ['error', '1tbs', { allowSingleLine: true }],
     'capitalized-comments': ['error', 'always', {
       line: {
         // Ignore all lines that have less characters than 20 and all lines that
         // start with something that looks like a variable name or code.
-        // eslint-disable-next-line max-len
-        ignorePattern: '.{0,20}$|[a-z]+ ?[0-9A-Z_.(/=:[#-]|std|http|ssh|ftp|(let|var|const) [a-z_A-Z0-9]+ =|[b-z] |[a-z]*[0-9].* ',
+        ignorePattern: '.{0,20}$|[a-z]+ ?[0-9A-Z_.(/=:[#-]|std|http|ssh|ftp',
         ignoreInlineComments: true,
         ignoreConsecutiveComments: true,
       },
       block: {
         ignorePattern: '.*',
       },
     }],
-    'comma-dangle': ['error', {
-      arrays: 'always-multiline',
-      exports: 'only-multiline',
-      functions: 'only-multiline',
-      imports: 'only-multiline',
-      objects: 'only-multiline',
-    }],
+    'comma-dangle': ['error', 'always-multiline'],
     'comma-spacing': 'error',
     'comma-style': 'error',
     'computed-property-spacing': 'error',
@@ -162,9 +163,9 @@ module.exports = {
       ObjectExpression: 'first',
       SwitchCase: 1,
     }],
-    'key-spacing': ['error', { mode: 'strict' }],
+    'key-spacing': 'error',
     'keyword-spacing': 'error',
-    'linebreak-style': ['error', 'unix'],
+    'linebreak-style': 'error',
     'max-len': ['error', {
       code: 120,
       ignorePattern: '^// Flags:',
@@ -178,7 +179,7 @@ module.exports = {
     'no-constant-condition': ['error', { checkLoops: false }],
     'no-constructor-return': 'error',
     'no-duplicate-imports': 'error',
-    'no-else-return': ['error', { allowElseIf: true }],
+    'no-else-return': 'error',
     'no-extra-parens': ['error', 'functions'],
     'no-lonely-if': 'error',
     'no-mixed-requires': 'error',
@@ -240,6 +241,12 @@ module.exports = {
         selector: "CallExpression[callee.name='isNaN']",
         message: 'Use Number.isNaN() instead of the global isNaN() function.',
       },
+      {
+        // TODO(@panva): move this to no-restricted-properties
+        // when https://github.com/eslint/eslint/issues/16412 is fixed
+        selector: "Identifier[name='webcrypto']",
+        message: 'Use `globalThis.crypto`.',
+      },
     ],
     'no-return-await': 'error',
     'no-self-compare': 'error',
@@ -285,7 +292,7 @@ module.exports = {
       named: 'never',
       asyncArrow: 'always',
     }],
-    'space-in-parens': ['error', 'never'],
+    'space-in-parens': 'error',
     'space-infix-ops': 'error',
     'space-unary-ops': 'error',
     'spaced-comment': ['error', 'always', {
@@ -307,26 +314,29 @@ module.exports = {
     'jsdoc/newline-after-description': 'off',
     'jsdoc/require-returns-description': 'off',
     'jsdoc/valid-types': 'off',
+    'jsdoc/no-defaults': 'off',
     'jsdoc/no-undefined-types': 'off',
     'jsdoc/require-param': 'off',
     'jsdoc/check-tag-names': 'off',
     'jsdoc/require-returns': 'off',
-    'jsdoc/require-property-description': 'off',
 
     // Custom rules from eslint-plugin-node-core
     'node-core/no-unescaped-regexp-dot': 'error',
     'node-core/no-duplicate-requires': 'error',
+    'node-core/prefer-proto': 'error',
   },
   globals: {
     ByteLengthQueuingStrategy: 'readable',
     CompressionStream: 'readable',
     CountQueuingStrategy: 'readable',
     CustomEvent: 'readable',
+    crypto: 'readable',
     Crypto: 'readable',
     CryptoKey: 'readable',
     DecompressionStream: 'readable',
     fetch: 'readable',
     FormData: 'readable',
+    navigator: 'readable',
     ReadableStream: 'readable',
     ReadableStreamDefaultReader: 'readable',
     ReadableStreamBYOBReader: 'readable',

.github/CODEOWNERS

@@ -1,56 +1,70 @@
 # Node.js Project Codeowners
 
-# 1. Codeowners must always be teams, never individuals
-# 2. Each codeowner team should contain at least one TSC member
-# 3. PRs touching any code with a codeowner must be signed off by at least one
-#    person on the code owner team.
+# This file does not define any requirements for landing PRs.
+# Its purpose is to allow automation of courtesy pings to the
+# relevant team(s) when any of the paths listed here are modified.
+# Criteria for landing PRs are defined in
+# https://github.com/nodejs/node/blob/main/doc/contributing/collaborator-guide.md#code-reviews.
+#
+# Codeowners must always be teams, never individuals.
 
 # tsc
 
 /.github/CODEOWNERS @nodejs/tsc
-/GOVERNANCE.md @nodejs/tsc
-/onboarding.md @nodejs/tsc
+/.github/PULL_REQUEST_TEMPLATE.md @nodejs/tsc
+/.github/ISSUE_TEMPLATE/* @nodejs/tsc
 /CODE_OF_CONDUCT.md @nodejs/tsc
 /CONTRIBUTING.md @nodejs/tsc
-/LICENSE @nodejs/tsc
 /doc/contributing/*.md @nodejs/tsc
+/GOVERNANCE.md @nodejs/tsc
+/LICENSE @nodejs/tsc
+/onboarding.md @nodejs/tsc
+
+# website
+/doc/api_assets @nodejs/website
+/doc/template.html @nodejs/website
+/tools/doc @nodejs/website
 
 # streams
 
 /lib/_stream* @nodejs/streams
+/lib/internal/streams/* @nodejs/streams
 /lib/stream.js @nodejs/streams
 /lib/stream/* @nodejs/streams
-/lib/internal/streams/* @nodejs/streams
 
 # net
 
+/deps/ada @nodejs/url
 /deps/cares @nodejs/net
-/doc/api/dns.md @nodejs/net
 /doc/api/dgram.md @nodejs/net
+/doc/api/dns.md @nodejs/net
 /doc/api/net.md @nodejs/net
 /lib/dgram.js @nodejs/net
 /lib/dns.js @nodejs/net
-/lib/net.js @nodejs/net
 /lib/internal/dgram.js @nodejs/net
 /lib/internal/dns/* @nodejs/net
+/lib/internal/js_stream_socket.js @nodejs/net
 /lib/internal/net.js @nodejs/net
 /lib/internal/socket_list.js @nodejs/net
-/lib/internal/js_stream_socket.js @nodejs/net
+/lib/internal/url.js @nodejs/url
+/lib/net.js @nodejs/net
+/lib/url.js @nodejs/url
 /src/cares_wrap.cc @nodejs/net
 /src/connect_wrap.* @nodejs/net
 /src/connection_wrap.* @nodejs/net
 /src/node_sockaddr* @nodejs/net
+/src/node_url.* @nodejs/url
 /src/tcp_wrap.* @nodejs/net
 /src/udp_wrap.* @nodejs/net
 
 # tls/crypto
 
+/lib/crypto.js @nodejs/crypto
 /lib/internal/crypto/* @nodejs/crypto
 /lib/internal/tls/* @nodejs/crypto @nodejs/net
-/lib/crypto.js @nodejs/crypto
 /lib/tls.js @nodejs/crypto @nodejs/net
-/src/node_crypto* @nodejs/crypto
 /src/crypto/* @nodejs/crypto
+/src/node_crypto* @nodejs/crypto
 
 # http
 
@@ -71,23 +85,25 @@
 /src/node_http2* @nodejs/http2 @nodejs/net
 /src/node_mem* @nodejs/http2
 
-# modules
+# modules, including loaders
 
-/doc/api/modules.md @nodejs/modules
-/doc/api/esm.md @nodejs/modules
-/doc/api/module.md @nodejs/modules
-/doc/api/packages.md @nodejs/modules
-/lib/module.js @nodejs/modules
-/lib/internal/modules/* @nodejs/modules
-/lib/internal/bootstrap/loaders.js @nodejs/modules
-/src/module_wrap* @nodejs/modules @nodejs/vm
+/doc/api/esm.md @nodejs/loaders
+/doc/api/module.md @nodejs/loaders
+/doc/api/modules.md @nodejs/loaders
+/doc/api/packages.md @nodejs/loaders
+/lib/internal/bootstrap/realm.js @nodejs/loaders
+/lib/internal/modules/* @nodejs/loaders
+/lib/internal/process/esm_loader.js @nodejs/loaders
+/lib/internal/process/execution.js @nodejs/loaders
+/lib/module.js @nodejs/loaders
+/src/module_wrap* @nodejs/loaders @nodejs/vm
 
 # Node-API
 
-/src/node_api* @nodejs/node-api
-/src/js_native_api* @nodejs/node-api
-/doc/contributing/adding-new-napi-api.md @nodejs/node-api
 /doc/api/n-api.md @nodejs/node-api
+/doc/contributing/adding-new-napi-api.md @nodejs/node-api
+/src/js_native_api* @nodejs/node-api
+/src/node_api* @nodejs/node-api
 
 # gyp
 
@@ -96,27 +112,63 @@
 /tools/gyp/**/* @nodejs/gyp
 
 # WASI
+
 /deps/uvwasi/ @nodejs/wasi
 /doc/api/wasi.md @nodejs/wasi
 /lib/wasi.js @nodejs/wasi
 /src/node_wasi* @nodejs/wasi
-/test/wasi/ @nodejs/wasi
 /test/fixtures/wasi/ @nodejs/wasi
+/test/wasi/ @nodejs/wasi
 
 # Startup
 
 /benchmark/misc/startup.js @nodejs/startup
-/src/node.cc @nodejs/startup
+/lib/internal/bootstrap/* @nodejs/startup
 /src/node_builtins* @nodejs/startup
+/src/node_realm* @nodejs/startup @nodejs/realm
 /src/node_snapshot* @nodejs/startup
-/lib/internal/bootstrap/* @nodejs/startup
+/src/node.cc @nodejs/startup
+/test/parallel/test-bootstrap-* @nodejs/startup
+/test/parallel/test-snapshot-* @nodejs/startup
 /tools/snapshot/* @nodejs/startup
 
 # V8
+
 /deps/v8/* @nodejs/v8-update
 /tools/v8_gypfiles/* @nodejs/v8-update
 
 # Actions
 
 /.github/workflows/* @nodejs/actions
 /tools/actions/* @nodejs/actions
+
+# Test runner
+
+/doc/api/test.md @nodejs/test_runner
+/lib/internal/main/test_runner.js @nodejs/test_runner
+/lib/internal/test_runner/* @nodejs/test_runner
+/lib/test.js @nodejs/test_runner
+/lib/test/reporters.js @nodejs/test_runner
+/test/parallel/test-runner-* @nodejs/test_runner
+
+# Single Executable Applications
+/deps/postject @nodejs/single-executable
+/doc/api/single-executable-applications.md @nodejs/single-executable
+/doc/contributing/maintaining/maintaining-single-executable-application-support.md @nodejs/single-executable
+/src/node_sea* @nodejs/single-executable
+/test/fixtures/postject-copy @nodejs/single-executable
+/test/parallel/test-single-executable-* @nodejs/single-executable
+/test/sequential/test-single-executable-* @nodejs/single-executable
+/tools/dep_updaters/update-postject.sh @nodejs/single-executable
+
+# Permission Model
+/doc/api/permissions.md @nodejs/security-wg
+/lib/internal/process/permission.js @nodejs/security-wg
+/src/permission/* @nodejs/security-wg
+
+# Dependency Update Tools
+
+/.github/workflows/tools.yml @nodejs/security-wg
+/.github/workflows/update-openssl.yml @nodejs/security-wg
+/.github/workflows/update-v8.yml @nodejs/security-wg @nodejs/v8-update
+/tools/dep_updaters/* @nodejs/security-wg

.github/ISSUE_TEMPLATE/1-bug-report.yml

@@ -33,7 +33,7 @@ body:
       label: How often does it reproduce? Is there a required condition?
   - type: textarea
     attributes:
-      label: What is the expected behavior?
+      label: What is the expected behavior? Why is that the expected behavior?
       description: If possible please provide textual output instead of screenshots.
   - type: textarea
     attributes:

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,15 +1,18 @@
 <!--
-Before submitting a pull request, please read
-https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md.
+Before submitting a pull request, please read:
 
-Commit message formatting guidelines:
-https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines
+- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
+- the commit message formatting guidelines at
+  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines
 
 For code changes:
 1. Include tests for any bug fixes or new features.
 2. Update documentation if relevant.
 3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.
 
+If you believe this PR should be highlighted in the Node.js CHANGELOG
+please add the `notable-change` label.
+
 Developer's Certificate of Origin 1.1
 
 By making a contribution to this project, I certify that: