-
Notifications
You must be signed in to change notification settings - Fork 211
Open
Labels
Description
The example at https://vaadin.com/docs/latest/components/custom-field has couple of issues:
- It doesn't compile: the
PhoneField.generateModelValue()
needs to returnPhone
instead ofString
- We should use
TextField
forcode
instead ofSelect
, sinceSelect
accepts generic parameter but there's none in the example and thus a compiler warning is emitted; the Select dropdown is also not populated with country codes.TextField
would probably be a simpler solution which would allow the reader to keep the focus on the CustomField example.