fix: copy all frontend resources from JAR files (#22264) (#22276)

Frontend resources in JAR files are filtered to only copy a hard-coded
set of file types like JS, TS, CSS, etc.
Since the resources are collected only from specific folders, the filter
is most likely unecessary and also makes it impossible to use fronted frameworks
that rely on custom extensions (e.g. Vue).
This change removes the file extension filter, allowing all files in META-INF/frontend
and META-INF/resources/frontend to be copied in the frontend generated folder.

Fixes #22208

Author: mcollovati

flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskCopyFrontendFiles.java

@@ -21,18 +21,19 @@
 import static com.vaadin.flow.server.Constants.RESOURCES_JAR_DEFAULT;
 
 /**
- * Copies JavaScript and CSS files from JAR files into a given folder.
+ * Copies all frontend resources from JAR files into a given folder.
+ * <p>
+ * The task considers "frontend resources" all files placed in
+ * {@literal META-INF/frontend}, {@literal META-INF/resources/frontend} and
+ * {@literal META-INF/resources/[**]/themes} folders.
  * <p>
  * For internal use only. May be renamed or removed in a future release.
  *
  * @since 2.0
  */
 public class TaskCopyFrontendFiles implements FallibleCommand {
-    private static final String[] WILDCARD_INCLUSIONS = new String[] {
-            "**/*.js", "**/*.js.map", "**/*.css", "**/*.css.map", "**/*.ts",
-            "**/*.ts.map", "**/*.tsx", "**/*.tsx.map" };
     private static final String WILDCARD_INCLUSION_APP_THEME_JAR = "**/themes/**/*";
-    private File targetDirectory;
+    private final File targetDirectory;
     private Set<File> resourceLocations = null;
 
     /**
@@ -71,10 +72,10 @@ public void execute() {
             } else {
                 jarContentsManager.copyIncludedFilesFromJarTrimmingBasePath(
                         location, RESOURCES_FRONTEND_DEFAULT, targetDirectory,
-                        WILDCARD_INCLUSIONS);
+                        "**/*");
                 jarContentsManager.copyIncludedFilesFromJarTrimmingBasePath(
                         location, COMPATIBILITY_RESOURCES_FRONTEND_DEFAULT,
-                        targetDirectory, WILDCARD_INCLUSIONS);
+                        targetDirectory, "**/*");
                 jarContentsManager.copyIncludedFilesFromJarTrimmingBasePath(
                         location, RESOURCES_JAR_DEFAULT, targetDirectory,
                         WILDCARD_INCLUSION_APP_THEME_JAR);

flow-server/src/test/java/com/vaadin/flow/server/frontend/FrontendResourcesAreCopiedAfterCleaningTest.java

@@ -49,13 +49,13 @@ public void setup() throws IOException, ExecutionFailedException {
     public void frontendResources_should_beCopiedFromJars_when_TaskUpdatePackagesRemovesThem()
             throws IOException, ExecutionFailedException {
         copyResources();
-        assertCopiedFrontendFileAmount(8);
+        assertCopiedFrontendFileAmount(17);
 
         performPackageClean();
         assertCopiedFrontendFileAmount(0);
 
         copyResources();
-        assertCopiedFrontendFileAmount(8);
+        assertCopiedFrontendFileAmount(17);
     }
 
     private void assertCopiedFrontendFileAmount(int fileCount)

flow-server/src/test/java/com/vaadin/flow/server/frontend/TaskCopyFrontendFilesTest.java

@@ -95,8 +95,9 @@ private void should_collectJsAndCssFilesFromJars(String jarFile,
         task.execute();
 
         List<String> files = TestUtils.listFilesRecursively(frontendDepsFolder);
-        Assert.assertEquals(10, files.size());
+        Assert.assertEquals(19, files.size());
 
+        // Check some resources
         Assert.assertTrue("TS resource should have been copied from jar file",
                 files.contains("example.ts"));
 
@@ -132,6 +133,21 @@ private void should_collectJsAndCssFilesFromJars(String jarFile,
         Assert.assertTrue(
                 "TSX resource source map should have been copied from jar file",
                 files.contains("react.tsx.map"));
+
+        Assert.assertTrue("JSX resource should have been copied from jar file",
+                files.contains("test.jsx"));
+
+        Assert.assertTrue(
+                "JSX resource source map should have been copied from jar file",
+                files.contains("test.jsx.map"));
+
+        Assert.assertTrue("HTML resource should have been copied from jar file",
+                files.contains("ExampleTemplate.html"));
+
+        Assert.assertFalse(
+                "Resource from unsupported frontend folder location should not have been copied from jar file",
+                files.contains("ignored.js"));
+
     }
 
     private static Set<File> jars(File... files) {