Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google app on iOS shows "browser too old" for Vaadin apps #11654

Closed
Artur- opened this issue Aug 27, 2021 · 5 comments · Fixed by #11821
Closed

Google app on iOS shows "browser too old" for Vaadin apps #11654

Artur- opened this issue Aug 27, 2021 · 5 comments · Fixed by #11821
Assignees
@denis-anisimov
Labels
bug Impact: Low prerelease version for platform 22.0.0 Released with Platform 14.7.1 Released with Platform 20.0.8 Released with Platform 21.0.2 Released with Platform 22.0.0.alpha4 Severity: Minor

Comments

@Artur-
Copy link
Member

Artur- commented Aug 27, 2021

The user agent the Google App reports is

Mozilla/5.0 (iPhone; CPU iPhone OS 14_7 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) GSA/117.0.321844219 Mobile/15E148 Safari/604.1

For reference, Safari on the same iOS device reports

Mozilla/5.0 (iPhone; CPU iPhone OS 14_7_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.1.2 Mobile/15E148 Safari/604.1

The Google App user agent does not contain the version information at all. Therefore, the logic added in #6518 by @bennewi looks at the webkit version. In this case it is 605.1.15 which according to the logic in the code is too old but in reality is Safari 14.1.

The user agent on latest Safari on desktop is

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.1.2 Safari/605.1.15

which makes me think that either the wikipedia page with webkit versions is completely wrong or then Safari does not report the actual web kit version used.
@Legioth
Copy link
Member

Legioth commented Aug 27, 2021 •
edited
Loading

I guess the most reliable indicator that is shared between both strings would be iPhone OS 14_7 since anything running iPhone OS 14.7 should be using the only browser engine that is allowed on iPhone.

@denis-anisimov denis-anisimov self-assigned this Sep 13, 2021
@denis-anisimov denis-anisimov mentioned this issue Sep 13, 2021
Merged
9 tasks
caalador pushed a commit that referenced this issue Sep 14, 2021
fix: make IPhone version above 14.7 browsers allowed for Vaadin (#11821)
a561e5e 
Fixes #11654
vaadin-bot pushed a commit that referenced this issue Sep 14, 2021
@vaadin-bot
fix: make IPhone version above 14.7 browsers allowed for Vaadin (#11821)
d74f1c6 
Fixes #11654
vaadin-bot pushed a commit that referenced this issue Sep 14, 2021
@vaadin-bot
fix: make IPhone version above 14.7 browsers allowed for Vaadin (#11821)
1b2225a 
Fixes #11654
vaadin-bot added a commit that referenced this issue Sep 14, 2021
@vaadin-bot
fix: make IPhone version above 14.7 browsers allowed for Vaadin (#11821…
f4b8ff4 
…) (#11835)

Fixes #11654

Co-authored-by: Denis <denis@vaadin.com>
caalador pushed a commit that referenced this issue Sep 14, 2021
@vaadin-bot
fix: make IPhone version above 14.7 browsers allowed for Vaadin (#11821…
75fca32 
…) (#11836)

Fixes #11654

Co-authored-by: Denis <denis@vaadin.com>
denis-anisimov pushed a commit that referenced this issue Sep 14, 2021
fix: make IPhone version above 14.7 browsers allowed for Vaadin (#11821)
282c602 
Fixes #11654
@denis-anisimov denis-anisimov mentioned this issue Sep 14, 2021
Merged
9 tasks
caalador pushed a commit that referenced this issue Sep 15, 2021
fix: make IPhone version above 14.7 browsers allowed for Vaadin (#11821…
255e6aa 
…) (#11844)

Fixes #11654
vaadin-bot pushed a commit that referenced this issue Sep 15, 2021
@vaadin-bot
fix: make IPhone version above 14.7 browsers allowed for Vaadin (#11821…
1e44532 
…) (#11844)

Fixes #11654
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha4 and is also targeting the upcoming stable 22.0.0 version.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 21.0.2.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 14.7.1.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 20.0.8.

@joheriks joheriks mentioned this issue Mar 11, 2022
Merged
@mcollovati mcollovati mentioned this issue Aug 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denis-anisimov denis-anisimov

Labels
bug Impact: Low prerelease version for platform 22.0.0 Released with Platform 14.7.1 Released with Platform 20.0.8 Released with Platform 21.0.2 Released with Platform 22.0.0.alpha4 Severity: Minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make IPhone version above 14.7 browsers allowed for Vaadin vaadin/flow
5 participants
@Artur- @Legioth @denis-anisimov @vaadin-bot @mshabarov