RouterLink url behaviour when using BeforeLeaveEvent.postpone

[FelixGaebler]

Description of the bug

When postponing a navigation with the BeforeLeaveListeners postpone() method the url gets lost.

1. Open the example

Working example (UI.getCurrent().navigate()):
3. Click on Report 4
4. Click on the button and watch the url inside your browser
5. It should stay the same

Broken example (RouterLink):
3. Click on Report 5
4. Click the link with an random uuid
5. Click yes
6. Repeat from 4 and watch the uuid disappear from the url again and again

Expected behavior

The url should stay the same as before and not navigate to the parent.

Minimal reproducible example

Implementation without RouterLink:
https://github.com/FelixGaebler/vaadin-bugs/tree/master/src/main/java/de/dataport/bugs/views/report4

Implementation with RouterLink:
https://github.com/FelixGaebler/vaadin-bugs/tree/master/src/main/java/de/dataport/bugs/views/report5

Versions

• Vaadin / Flow version: 24.1.5
• Java version: 17
• OS version: Ubuntu 22

[TatuLund]

I a refactor RouterLink to take all the parameters in constructor it works. Note, RouteAlias is not necessary as you can use route pattern ":test?" to mark parameter optional with "?".

@PageTitle("Report 5")
@Route(value = "report-5/:test?", layout = MainLayout.class)
public class Report5View extends Main
        implements BeforeEnterObserver, BeforeLeaveObserver {

    private final RouterLink link;

    public Report5View() {
        this.link = new RouterLink("initial", Report5View.class,
                new RouteParameters(
                        new RouteParam("test", UUID.randomUUID().toString())));
        add(this.link);
    }

    @Override
    public void beforeEnter(BeforeEnterEvent event) {
        String parameter = event.getRouteParameters().get("test").orElse(null);
        if (parameter == null) {
            event.rerouteTo(Report5View.class, new RouteParameters(
                    new RouteParam("test", UUID.randomUUID().toString())));
        } else {
            this.link.setText(parameter);
            this.link.setRoute(Report5View.class, new RouteParameters(
                    new RouteParam("test", UUID.randomUUID().toString())));
        }
    }

    @Override
    public void beforeLeave(BeforeLeaveEvent event) {
        BeforeLeaveEvent.ContinueNavigationAction action = event.postpone();

        ConfirmDialog dialog = new ConfirmDialog();
        dialog.setText("Navigate?");
        dialog.setConfirmButton("Yes", e -> action.proceed());
        dialog.setCancelText("No");
        dialog.setCancelable(true);
        dialog.open();
    }

}

[felix-office]

I don't know what you checked there but it's still the same for me with your "refactoring" @TatuLund

1. Click on Report 5
2. Click the link with an random uuid
3. Click yes
4. Click on "Report 4" in the navigation
5. Watch the url, the uuid disappeared while the dialog is being opened
6. Click no on the confirm
7. You are still on the same page before as you cancelled the navigation but the url is now wrong

[caalador]

The router link for some reason reverts to what ever the navigation event url was when the postpone event happens.
So If you navigated in with report-5/home the url reverts to report-5/home each time.
Feels like some client side issue as there were at least no messages from the server that would have the old data, also the server activeView and lastHandled do not contain the original data.

[vaadin-bot]

This ticket/PR has been released with Vaadin 24.1.11.

[vaadin-bot]

This ticket/PR has been released with Vaadin 24.3.0.alpha1 and is also targeting the upcoming stable 24.3.0 version.