Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: router-link postpone navigation (#17647) (CP: 24.1) #17664

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

Fixes issue with update timing
when postponing a router-link
as the navigation goes through
the vaadin-router.

Fixes #17528
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) September 20, 2023 08:49
@github-actions
Copy link

github-actions bot commented Sep 20, 2023

Test Results

1 000 files  +  1  1 000 suites  +1   1h 2m 36s ⏱️ + 2m 19s
6 356 tests +  2  6 315 ✔️ +  2  41 💤 ±0  0 ±0 
6 609 runs  +11  6 561 ✔️ +11  48 💤 ±0  0 ±0 

Results for commit 45f3b97. ± Comparison against base commit 4672d4d.

♻️ This comment has been updated with latest results.

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vaadin-bot vaadin-bot merged commit 4b2217a into 24.1 Sep 21, 2023
25 of 26 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-17647-to-24.1-1695199360863 branch September 21, 2023 11:25
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.1.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants