Forwarding is not working correctly

[jameskerr06]

Description of the bug

We have a landing route at /
The landing route checks details about the user and forwards to either /admin or /main
The MainRoute at /main accepts a "filter" query parameter. If no parameter is set, it forwards the request to /main?filter=default

So if the user hits the root URL / I expect them to be taken to /main?filter=default
They should see that URL in the address bar of their browser and the MainRoute beforeEnter method should have run for /main?filter=default

What actually happens is only the first forward hop so the user is forwarded from / to /main but not to /main?filter=default
I added some print statements to the app which shows that the app does call forwardTo("/main?filter=default")

Expected behavior

see description

Minimal reproducible example

This sample is using the latest v24 but I need the issue fixed in v23

routing-query-params-issue.zip

Versions

• Vaadin / Flow version: 23.3.23
• Java version: 17
• OS version: osx

[TatuLund]

I think this is duplicate of #14553

I.e. forwardTo works as designed here. It uses the navigation state and retains original query parameters of it (which are none), the added new query parameters are not used. The PR that closed 14553 adds new overloading methods to forwardTo that makes possible to add new query parameters while forwarding.

[mcollovati]

As Tatu said, support for query parameters in reroute and forward has been added in Flow 24.2.

However, for this specific use case, it won't work because the navigation target is the same (from main to main?filter).

We should probably expand the fix to introduced by #17576, considering also BeforeEvent query parameters when checking if forward/reroute should be performed.

Maybe something like

boolean queryParameterChanged = beforeEvent.hasRedirectQueryParameters()
        && !beforeEvent.getRedirectQueryParameters().equals(event.getLocation().getQueryParameters());

[vaadin-bot]

This ticket/PR has been released with Vaadin 23.3.25.

[vaadin-bot]

This ticket/PR has been released with Vaadin 24.1.11.

[vaadin-bot]

This ticket/PR has been released with Vaadin 24.3.0.alpha1 and is also targeting the upcoming stable 24.3.0 version.