Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Production mode flow-build-info.json contains local file paths #6336

Closed
Legioth opened this issue Aug 27, 2019 · 2 comments · Fixed by #6405
Closed

Production mode flow-build-info.json contains local file paths #6336

Legioth opened this issue Aug 27, 2019 · 2 comments · Fixed by #6405
Labels
bug
Milestone
2.0.11

Comments

@Legioth
Copy link
Member

Legioth commented Aug 27, 2019

The production build (e.g. mvn package -Pproduction with Beverage Buddy) creates a flow-build-info.json file which contains redundant local file path references (e.g. npmFolder).

This information is completely redundant for running the application in production mode, and may cause some confusion since it's not apparent that the path will not be used.

For this reason, it would be better if build-frontend would produce a json file without those properties.
@alejandro-du alejandro-du mentioned this issue Aug 29, 2019
Closed
@pleku pleku added the bug label Aug 30, 2019
@pleku pleku moved this from Needs triage to P3 - Low Priority in OLD Vaadin Flow bugs & maintenance (Vaadin 10+) Aug 30, 2019
@joheriks
Copy link
Contributor

The generation of flow-build-info.json occurs in PrepareFrontendMojo of flow-maven-plugin.

@Legioth
Copy link
Member Author

Legioth commented Sep 2, 2019

This isn't only a cosmetic issue that might cause confusion. vaadin/addon-template#18 in combination with #6233 may cause a situation where the implicit configuration based on cwd won't be applied because a flow-build-info.json file might be on the classpath from an add-on jar that accidentally includes it.

caalador added a commit that referenced this issue Sep 5, 2019
@caalador
Fail for non existing folders in dev mode.
afa5744 
If the npm or frontend folders do not exist
in the filesystem throw exception.

Fixes #6396
Closes #6336
@caalador caalador mentioned this issue Sep 5, 2019
Merged
OLD Vaadin Flow bugs & maintenance (Vaadin 10+) automation moved this from P3 - Low Priority to Closed - pending release Sep 6, 2019
ujoni pushed a commit that referenced this issue Sep 6, 2019
@caalador @ujoni
Fail for non existing folders in dev mode. (#6405)
4d90841 
If the npm or frontend folders do not exist in the 
filesystem throw exception (Only fail if the frontend
folder is defined outside of the npm folder)

If the frontend folder is a subfolder to the npm, folder
and the npm folder exists do not fail as we will create
the empty frontend folder.

Fixes #6396
Closes #6336
denis-anisimov pushed a commit that referenced this issue Sep 9, 2019
@caalador
Fail for non existing folders in dev mode. (#6405)
1fb2569 
If the npm or frontend folders do not exist in the 
filesystem throw exception (Only fail if the frontend
folder is defined outside of the npm folder)

If the frontend folder is a subfolder to the npm, folder
and the npm folder exists do not fail as we will create
the empty frontend folder.

Fixes #6396
Closes #6336
caalador added a commit that referenced this issue Sep 9, 2019
@caalador
Fail for non existing folders in dev mode. (#6405)
5536cb8 
If the npm or frontend folders do not exist in the 
filesystem throw exception (Only fail if the frontend
folder is defined outside of the npm folder)

If the frontend folder is a subfolder to the npm, folder
and the npm folder exists do not fail as we will create
the empty frontend folder.

Fixes #6396
Closes #6336
@mehdi-vaadin mehdi-vaadin added this to the 2.0.11 milestone Sep 16, 2019
@mehdi-vaadin mehdi-vaadin moved this from Closed - pending release to Closed - released in OLD Vaadin Flow bugs & maintenance (Vaadin 10+) Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.0.11
Development

Successfully merging a pull request may close this issue.

Fail for non existing folders in dev mode. vaadin/flow
4 participants
@Legioth @pleku @joheriks @mehdi-vaadin