Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global style re-introduction for embedded web components #7005

Closed
ujoni opened this issue Nov 22, 2019 · 0 comments
Closed

Global style re-introduction for embedded web components #7005

ujoni opened this issue Nov 22, 2019 · 0 comments
Labels
bug embedding flow Issues for embedding Flow applications
Milestone
2.2.0.alpha6

Comments

@ujoni
Copy link
Contributor

ujoni commented Nov 22, 2019

After #6962 global styles have been removed from embedded web components (and as a result from Vaadin Portlets). This affects elements such as critical error display, which is no longer styled from embedded web components.

The styles should not intrude on the global scope but should be available for use inside the embedded web components (and so all <body> targeted dom changes should target the embedded web component, if it makes sense.
@ujoni ujoni added bug embedding flow Issues for embedding Flow applications labels Nov 22, 2019
@ujoni ujoni self-assigned this Nov 25, 2019
@ujoni ujoni mentioned this issue Nov 25, 2019
Closed
@joheriks joheriks added this to the 2.2.0.alpha6 milestone Dec 9, 2019
@joheriks joheriks mentioned this issue Dec 9, 2019
Merged
@joheriks joheriks closed this as completed Dec 9, 2019
@caalador caalador mentioned this issue Mar 11, 2020
Closed
@denis-anisimov denis-anisimov mentioned this issue Jun 15, 2020
Closed
@caalador caalador mentioned this issue Apr 21, 2022
Merged
7 tasks
This was referenced Aug 1, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug embedding flow Issues for embedding Flow applications
Projects
None yet
Milestone
2.2.0.alpha6
Development

No branches or pull requests
2 participants
@joheriks @ujoni