Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An embedded component should not change page styles #5363

Closed
Artur- opened this issue Mar 28, 2019 · 8 comments
Closed

An embedded component should not change page styles #5363

Artur- opened this issue Mar 28, 2019 · 8 comments
Assignees
@denis-anisimov
Labels
BFP Bugfix priority, also known as Warranty bug embedding flow Issues for embedding Flow applications Impact: Low Severity: Major
Milestone
2.2.0.alpha6

Comments

@Artur-
Copy link
Member

Artur- commented Mar 28, 2019

If you embed an exported web component, the margins for the <body> element disappears.
@ZheSun88 ZheSun88 added bug embedding flow Issues for embedding Flow applications labels Mar 28, 2019
@ZheSun88
Copy link
Contributor

possible to make a sample project for us to debug?

Artur- added a commit to Artur-/vaadin-jsf-embedding that referenced this issue Mar 28, 2019
@Artur-
Workaround for vaadin/flow#5363
3d47a88
@pleku
Copy link
Contributor

pleku commented Apr 8, 2019 •
edited
Loading

So the defaults described in https://github.com/vaadin/flow/blob/master/flow-server/src/main/java/com/vaadin/flow/component/page/BodySize.java#L41 should not be applied for embedded Flow case, nor the annotation values.

@jouni
Copy link
Member

jouni commented Jul 5, 2019 •
edited
Loading

Also, none of the global Lumo style modules should be included (<style include="lumo-color lumo-typography">), or even imported explicitly. The components themes will import the necessary modules already.

@caalador
Copy link
Contributor

This should be retested as there was a fix for 2.2.0.alpha6 on this issue: #7005

@pleku pleku added the BFP Bugfix priority, also known as Warranty label Mar 11, 2020
@denis-anisimov denis-anisimov self-assigned this Mar 12, 2020
@denis-anisimov
Copy link
Contributor

Can't reproduce this neither with master nor with 2.2.
So it's fixed.

@pleku pleku added this to the 2.2.0.alpha6 milestone Mar 13, 2020
@pleku
Copy link
Contributor

pleku commented Mar 13, 2020

Just want to clarify here that the fix for this issue has not been picked to 2.1 / 14.1 intentionally. The fix is available in 14.2, so we recommend updating to that one.

In case switching to 14.2 prereleases now is not possible and getting the fix to 14.1 would be critical, we could pick the change to 14.1, but we will do so only on request as there is some extra work to adapt the change there.

@martinisraelsen
Copy link

Thanks @pleku. Any thoughts on when 14.2 will be released? We're looking to deploy in two weeks.

@Legioth Legioth mentioned this issue Mar 25, 2020
Closed
@fschon
Copy link

fschon commented Jun 11, 2020

Hi, I still have the same problems in 14.2.1.

@jouni jouni mentioned this issue Jun 12, 2020
Closed
@Legioth Legioth mentioned this issue Jan 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denis-anisimov denis-anisimov

Labels
BFP Bugfix priority, also known as Warranty bug embedding flow Issues for embedding Flow applications Impact: Low Severity: Major
Projects
None yet
Milestone
2.2.0.alpha6
Development

No branches or pull requests
9 participants
@jouni @Artur- @pleku @caalador @martinisraelsen @denis-anisimov @fschon @ZheSun88 @jm-ferreira