Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the documentation to refer to Lit in all parts and not refer to Polymer in examples #8924

Closed
4 tasks done
pleku opened this issue Aug 31, 2020 · 6 comments
Closed
4 tasks done

Comments

@pleku
Copy link
Contributor

pleku commented Aug 31, 2020

The documentation should not refer to Polymer anymore in any examples and the docs should be highlighting the approach of having layouts in html/js and UI logic in Java:

@joheriks
Copy link
Contributor

joheriks commented Sep 14, 2020

Do we plan to upgrade the component starter to integrate a Lit component instead of a Polymer one? It is linked in the documentation on integrating a web component.

@pleku
Copy link
Contributor Author

pleku commented Sep 14, 2020

Do we plan to upgrade the component starter to integrate a Lit component instead of a Polymer one? It is linked in the documentation on integrating a web component.

It is the third point in the AC ?

The component add-on starter should be not based on a Polymer component https://github.com/vaadin/component-starter-flow either using a VanillaJS web component or maybe a lit based web component

@joheriks
Copy link
Contributor

joheriks commented Sep 14, 2020

Yes, I noticed, but is it part of this ticket to do the actual modification of the starter?

@pleku
Copy link
Contributor Author

pleku commented Sep 14, 2020

Yes it was discussed as such, but I think it is fine if you want to split it out.

@joheriks
Copy link
Contributor

Split out to ticket vaadin/npm-addon-template#236. I suppose mwc-slider would be a reasonable substitute.

@joheriks
Copy link
Contributor

joheriks commented Sep 14, 2020

Just checking: does this part

It should explain what limitations there are, like changing text content will replace all child elements

refer to the situation where the template is e.g.:

      <div id="myDiv">
        <vaadin-button id="myButton">VButton</vaadin-button>
      </div>

and doing myDiv.setText("abc") in the Java side causing the myButton child to disappear, or something else?

pleku pushed a commit to vaadin/flow-and-components-documentation that referenced this issue Sep 16, 2020
Co-authored-by: caalador <mikael.grankvist@gmail.com>

Part of vaadin/flow#8924
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants