Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add tests for log level change in MapSyncRpcHandler #13517

Merged
merged 3 commits into from
Apr 13, 2022
Merged

test: add tests for log level change in MapSyncRpcHandler #13517

merged 3 commits into from
Apr 13, 2022

Conversation

taefi
Copy link
Contributor

@taefi taefi commented Apr 12, 2022

Description

Tests added for the log
level change introduced
in #13509

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed a self-review and corrected misspellings.

@taefi taefi requested a review from caalador April 12, 2022 21:26
@CLAassistant
Copy link

CLAassistant commented Apr 12, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Apr 12, 2022 •
edited
Loading

Unit Test Results

   955 files  ±0     955 suites  ±0   49m 35s ⏱️ +13s
6 204 tests ±0  6 155 ✔️ ±0  49 💤 ±0  0 ❌ ±0 
6 422 runs  +9  6 367 ✔️ +9  55 💤 ±0  0 ❌ ±0 

Results for commit 4cd59ff. ± Comparison against base commit 0e7bcb5.

♻️ This comment has been updated with latest results.

@taefi taefi enabled auto-merge (squash) April 13, 2022 07:46
@taefi taefi merged commit ba2c87a into master Apr 13, 2022
@taefi taefi deleted the appendix-tests-for-13509 branch April 13, 2022 11:31
vaadin-bot pushed a commit that referenced this pull request Apr 13, 2022
@taefi @vaadin-bot
test: add tests for log level change in MapSyncRpcHandler (#13517)
9c8a10a 
* test: add tests for log level change in MapSyncRpcHandler
vaadin-bot pushed a commit that referenced this pull request Apr 13, 2022
@taefi @vaadin-bot
test: add tests for log level change in MapSyncRpcHandler (#13517)
30b4270 
* test: add tests for log level change in MapSyncRpcHandler
vaadin-bot pushed a commit that referenced this pull request Apr 13, 2022
@taefi @vaadin-bot
test: add tests for log level change in MapSyncRpcHandler (#13517)
bc524f0 
* test: add tests for log level change in MapSyncRpcHandler
@vaadin-bot
Copy link
Collaborator

Hi @taefi and @taefi, when i performed cherry-pick to this commit to 2.7, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick ba2c87a
error: could not apply ba2c87a... test: add tests for log level change in MapSyncRpcHandler (#13517)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

taefi added a commit that referenced this pull request Apr 13, 2022
@taefi
test: add tests for log level change in MapSyncRpcHandler (#13517)
a9d2497 
(cherry picked from commit ba2c87a)
@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

taefi added a commit that referenced this pull request Apr 14, 2022
@taefi
test: add tests for log level change in MapSyncRpcHandler (#13517) (#…
429d8cc 
…13534)

(cherry picked from commit ba2c87a)
taefi added a commit that referenced this pull request Apr 14, 2022
@vaadin-bot @taefi
test: add tests for log level change in MapSyncRpcHandler (#13517) (#…
a957038 
…13530)

* test: add tests for log level change in MapSyncRpcHandler

Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com>
taefi added a commit that referenced this pull request Apr 19, 2022
@vaadin-bot @taefi
test: add tests for log level change in MapSyncRpcHandler (#13517) (#…
97387c3 
…13528)

* test: add tests for log level change in MapSyncRpcHandler

Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com>
taefi added a commit that referenced this pull request Apr 19, 2022
@vaadin-bot @taefi
test: add tests for log level change in MapSyncRpcHandler (#13517) (#…
cdcf25e 
…13529)

* test: add tests for log level change in MapSyncRpcHandler

Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caalador caalador caalador approved these changes

Assignees
No one assigned
Labels
cherry-picked-2.7 cherry-picked-2.8 cherry-picked-9.0 cherry-picked-23.0 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taefi @CLAassistant @vaadin-bot @caalador