refactor!: Rename dev mode gizmo to dev tools #13679

Artur- · 2022-05-04T12:34:07Z

No description provided.

manolo · 2022-05-04T13:10:19Z

Still files with gizmo occurrences

flow-client/webpack.tests.config.js
flow-tests/test-dev-mode/src/test/java/com/vaadin/flow/uitest/ui/DebugWindowErrorHandlingIT.java
flow-tests/test-dev-mode/src/test/java/com/vaadin/flow/uitest/ui/DebugWindowFeatureFlagsIT.java
flow-tests/test-dev-mode/src/test/java/com/vaadin/flow/uitest/ui/DependencyIT.java
flow-tests/test-dev-mode/src/test/java/com/vaadin/flow/uitest/ui/FeatureIT.java
flow-tests/test-frontend/vite-basics/src/test/java/com/vaadin/viteapp/BasicsIT.java
flow-tests/test-live-reload/src/test/java/com/vaadin/flow/uitest/ui/JavaLiveReloadIT.java
flow-tests/test-live-reload/src/test/java/com/vaadin/flow/uitest/ui/PreserveOnRefreshLiveReloadIT.java
flow-tests/test-misc/src/main/java/com/vaadin/flow/misc/ui/ProdModeConfigView.java
flow-tests/test-misc/src/test/java/com/vaadin/flow/misc/ui/ProdModeConfigIT.java
flow-tests/test-root-context/src/test/java/com/vaadin/flow/ClientResourceIT.java
flow-tests/test-root-ui-context/src/main/java/com/vaadin/flow/uitest/gizmo/DevModeGizmoView.java
flow-tests/test-root-ui-context/src/main/java/com/vaadin/flow/uitest/servlet/DevModeGizmoDisabledServlet.java
flow-tests/test-root-ui-context/src/test/java/com/vaadin/flow/uitest/ui/gizmo/DevModeGizmoIT.java

And files that might be renamed

flow-tests/test-root-ui-context/src/test/java/com/vaadin/flow/uitest/ui/gizmo/DevModeGizmoIT.java
flow-tests/test-root-ui-context/src/main/java/com/vaadin/flow/uitest/servlet/DevModeGizmoDisabledServlet.java
flow-tests/test-root-ui-context/src/main/java/com/vaadin/flow/uitest/gizmo/DevModeGizmoView.java

github-actions · 2022-05-04T13:10:22Z

Unit Test Results

  964 files ±0   964 suites ±0 46m 35s ⏱️ + 2m 27s
6 267 tests ±0 6 219 ✔️ ±0 48 💤 ±0 0 ❌ ±0
6 492 runs - 3 6 438 ✔️ - 3 54 💤 ±0 0 ❌ ±0

Results for commit beff607. ± Comparison against base commit 3517ce4.

♻️ This comment has been updated with latest results.

sonatype-lift · 2022-05-04T13:13:35Z

flow-server/src/main/java/com/vaadin/flow/router/internal/AbstractNavigationStateRenderer.java

@@ -961,7 +961,7 @@ private static void warnAboutPreserveOnRefreshAndLiveReloadCombo(UI ui) {
        if (!configuration.isProductionMode()


NULL_DEREFERENCE: object configuration last assigned on line 960 could be null and is dereferenced at line 961.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-04T15:01:14Z

flow-server/src/main/java/com/vaadin/flow/router/internal/AbstractNavigationStateRenderer.java

@@ -961,7 +961,7 @@ private static void warnAboutPreserveOnRefreshAndLiveReloadCombo(UI ui) {
        if (!configuration.isProductionMode()


NULL_DEREFERENCE: object configuration last assigned on line 960 could be null and is dereferenced at line 961.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-04T15:41:56Z

flow-server/src/main/java/com/vaadin/flow/router/internal/AbstractNavigationStateRenderer.java

@@ -961,7 +961,7 @@ private static void warnAboutPreserveOnRefreshAndLiveReloadCombo(UI ui) {
        if (!configuration.isProductionMode()


NULL_DEREFERENCE: object configuration last assigned on line 960 could be null and is dereferenced at line 961.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-05T06:07:39Z

flow-server/src/main/java/com/vaadin/flow/router/internal/AbstractNavigationStateRenderer.java

@@ -961,7 +961,7 @@ private static void warnAboutPreserveOnRefreshAndLiveReloadCombo(UI ui) {
        if (!configuration.isProductionMode()


NULL_DEREFERENCE: object configuration last assigned on line 960 could be null and is dereferenced at line 961.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-06T08:19:42Z

flow-server/src/main/java/com/vaadin/flow/router/internal/AbstractNavigationStateRenderer.java

@@ -961,7 +961,7 @@ private static void warnAboutPreserveOnRefreshAndLiveReloadCombo(UI ui) {
        if (!configuration.isProductionMode()


NULL_DEREFERENCE: object configuration last assigned on line 960 could be null and is dereferenced at line 961.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-06T08:44:31Z

flow-server/src/main/java/com/vaadin/flow/router/internal/AbstractNavigationStateRenderer.java

@@ -961,7 +961,7 @@ private static void warnAboutPreserveOnRefreshAndLiveReloadCombo(UI ui) {
        if (!configuration.isProductionMode()


NULL_DEREFERENCE: object configuration last assigned on line 960 could be null and is dereferenced at line 961.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-06T14:12:57Z

flow-server/src/main/java/com/vaadin/flow/router/internal/AbstractNavigationStateRenderer.java

@@ -961,7 +961,7 @@ private static void warnAboutPreserveOnRefreshAndLiveReloadCombo(UI ui) {
        if (!configuration.isProductionMode()


NULL_DEREFERENCE: object configuration last assigned on line 960 could be null and is dereferenced at line 961.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-07T07:46:15Z

flow-server/src/main/java/com/vaadin/flow/router/internal/AbstractNavigationStateRenderer.java

@@ -961,7 +961,7 @@ private static void warnAboutPreserveOnRefreshAndLiveReloadCombo(UI ui) {
        if (!configuration.isProductionMode()


NULL_DEREFERENCE: object configuration last assigned on line 960 could be null and is dereferenced at line 961.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonarcloud · 2022-05-11T11:39:40Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

sonatype-lift · 2022-05-11T11:44:17Z

flow-server/src/main/java/com/vaadin/flow/router/internal/AbstractNavigationStateRenderer.java

@@ -961,7 +961,7 @@ private static void warnAboutPreserveOnRefreshAndLiveReloadCombo(UI ui) {
        if (!configuration.isProductionMode()


NULL_DEREFERENCE: object configuration last assigned on line 960 could be null and is dereferenced at line 961.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

mshabarov

@Artur- is there a good reason to pick this change to 23.1 ? Since it's just a naming, I'd not introduce breaking changes into beta version.

Artur- · 2022-05-11T13:39:57Z

The only reason would be to reduce backporting issues by keeping the branches as similar as possible

mshabarov · 2022-05-11T14:24:47Z

The only reason would be to reduce backporting issues by keeping the branches as similar as possible

Makes sense!

vaadin-bot · 2022-09-07T10:23:24Z

This ticket/PR has been released with Vaadin 23.2.0.

Artur- force-pushed the dev-tools branch 2 times, most recently from dbad6b9 to e0d328a Compare May 4, 2022 12:35

vaadin-bot added the +1.0.0 label May 4, 2022

Artur- force-pushed the dev-tools branch 2 times, most recently from bd288ce to b61581f Compare May 4, 2022 12:48

sonatype-lift bot reviewed May 4, 2022

View reviewed changes

Artur- force-pushed the dev-tools branch from b61581f to be698be Compare May 4, 2022 14:35

Artur- changed the title ~~chore!: Rename dev mode gizmo to dev tools~~ refactor!: Rename dev mode gizmo to dev tools May 4, 2022

sonatype-lift bot reviewed May 4, 2022

View reviewed changes

Artur- force-pushed the dev-tools branch from be698be to f016fb7 Compare May 4, 2022 15:16

sonatype-lift bot reviewed May 4, 2022

View reviewed changes

Artur- force-pushed the dev-tools branch from f016fb7 to b5ab3c1 Compare May 5, 2022 05:37

sonatype-lift bot reviewed May 5, 2022

View reviewed changes

sonatype-lift bot reviewed May 6, 2022

View reviewed changes

sonatype-lift bot reviewed May 7, 2022

View reviewed changes

mshabarov requested a review from mcollovati May 9, 2022 11:26

chore!: Rename dev mode gizmo to dev tools

beff607

Artur- force-pushed the dev-tools branch from e996b4c to beff607 Compare May 11, 2022 11:16

Artur- added the target/23.1 label May 11, 2022

sonatype-lift bot reviewed May 11, 2022

View reviewed changes

mshabarov self-requested a review May 11, 2022 11:46

mshabarov approved these changes May 11, 2022

View reviewed changes

mshabarov merged commit b182ea8 into master May 11, 2022

mshabarov deleted the dev-tools branch May 11, 2022 14:25

vaadin-bot pushed a commit that referenced this pull request May 11, 2022

chore!: Rename dev mode gizmo to dev tools (#13679)

1ff9a79

vaadin-bot added the cherry-picked-23.1 label May 11, 2022

Artur- mentioned this pull request May 12, 2022

Fix: devmode popup will show Hilla instead of Vaadin in Hilla applications #13725

Merged

8 tasks

Artur- pushed a commit that referenced this pull request May 12, 2022

chore!: Rename dev mode gizmo to dev tools (#13679) (#13742)

d1b7608

mshabarov mentioned this pull request Aug 15, 2022

Update V14 > V23 upgrade guide after 23.2 release vaadin/docs#1606

Closed

vaadin-bot added the Released with Vaadin 23.2.0 label Sep 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor!: Rename dev mode gizmo to dev tools #13679

refactor!: Rename dev mode gizmo to dev tools #13679

Artur- commented May 4, 2022

manolo commented May 4, 2022 •

edited

Loading

github-actions bot commented May 4, 2022 •

edited

Loading

sonatype-lift bot May 4, 2022

sonatype-lift bot May 4, 2022

sonatype-lift bot May 4, 2022

sonatype-lift bot May 5, 2022

sonatype-lift bot May 6, 2022

sonatype-lift bot May 6, 2022

sonatype-lift bot May 6, 2022

sonatype-lift bot May 7, 2022

sonarcloud bot commented May 11, 2022

sonatype-lift bot May 11, 2022

mshabarov left a comment

Artur- commented May 11, 2022

mshabarov commented May 11, 2022

vaadin-bot commented Sep 7, 2022

		@@ -961,7 +961,7 @@ private static void warnAboutPreserveOnRefreshAndLiveReloadCombo(UI ui) {
		if (!configuration.isProductionMode()

refactor!: Rename dev mode gizmo to dev tools #13679

refactor!: Rename dev mode gizmo to dev tools #13679

Conversation

Artur- commented May 4, 2022

manolo commented May 4, 2022 • edited Loading

github-actions bot commented May 4, 2022 • edited Loading

Unit Test Results

sonatype-lift bot May 4, 2022

Choose a reason for hiding this comment

sonatype-lift bot May 4, 2022

Choose a reason for hiding this comment

sonatype-lift bot May 4, 2022

Choose a reason for hiding this comment

sonatype-lift bot May 5, 2022

Choose a reason for hiding this comment

sonatype-lift bot May 6, 2022

Choose a reason for hiding this comment

sonatype-lift bot May 6, 2022

Choose a reason for hiding this comment

sonatype-lift bot May 6, 2022

Choose a reason for hiding this comment

sonatype-lift bot May 7, 2022

Choose a reason for hiding this comment

sonarcloud bot commented May 11, 2022

sonatype-lift bot May 11, 2022

Choose a reason for hiding this comment

mshabarov left a comment

Choose a reason for hiding this comment

Artur- commented May 11, 2022

mshabarov commented May 11, 2022

vaadin-bot commented Sep 7, 2022

manolo commented May 4, 2022 •

edited

Loading

github-actions bot commented May 4, 2022 •

edited

Loading